Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Run release on release creation #48

Closed
wants to merge 2 commits into from

Conversation

passy
Copy link
Member

@passy passy commented Feb 22, 2021

Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.

Test Plan:
testinprod

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@passy passy force-pushed the github-action-release-create branch from dcc7963 to 8b4e713 Compare February 23, 2021 14:15
@facebook-github-bot
Copy link
Contributor

@passy has updated the pull request. You must reimport the pull request before landing.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@passy merged this pull request in d521fc5.

facebook-github-bot pushed a commit to facebookarchive/profilo that referenced this pull request Feb 24, 2021
Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.

Docs for this in D26607139.

Pull Request resolved: facebookincubator/fbjni#48

Test Plan:
Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release).

https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true

Reviewed By: nikoant

Differential Revision: D26583351

Pulled By: passy

fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
facebook-github-bot pushed a commit to facebook/hermes that referenced this pull request Feb 24, 2021
Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.

Docs for this in D26607139.

Pull Request resolved: facebookincubator/fbjni#48

Test Plan:
Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release).

https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true

Reviewed By: nikoant

Differential Revision: D26583351

Pulled By: passy

fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
EduardoCostaom pushed a commit to EduardoCostaom/profilo that referenced this pull request Nov 2, 2022
Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.

Docs for this in D26607139.

Pull Request resolved: facebookincubator/fbjni#48

Test Plan:
Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release).

https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true

Reviewed By: nikoant

Differential Revision: D26583351

Pulled By: passy

fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants