-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[actions] Run release on release creation #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
dcc7963
to
8b4e713
Compare
@passy has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead. Docs for this in D26607139. Pull Request resolved: facebookincubator/fbjni#48 Test Plan: Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release). https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true Reviewed By: nikoant Differential Revision: D26583351 Pulled By: passy fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
Summary: Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead. Docs for this in D26607139. Pull Request resolved: facebookincubator/fbjni#48 Test Plan: Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release). https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true Reviewed By: nikoant Differential Revision: D26583351 Pulled By: passy fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
Summary: Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead. Docs for this in D26607139. Pull Request resolved: facebookincubator/fbjni#48 Test Plan: Ran it on my fork. It failed but because there were unclosed previous updates, which is in fact expected (and quite useful, too, because it means we don't have a stray release). https://github.com/passy/fbjni/runs/1961026784?check_suite_focus=true Reviewed By: nikoant Differential Revision: D26583351 Pulled By: passy fbshipit-source-id: 1eee0b8c5b294a778da95c7017a9fbe4f5232354
Summary:
Pushing tags against existing commits doesn't seem to trigger the action, so let's list releases here instead.
Test Plan:
testinprod