Use process.execPath to spawn node subprocess

[anuraaga]

Instead of requiring Node to be on the system PATH.

Currently, react-scripts spawns scripts such as test, build by specifying an executable name, node. This requires node to be on the system PATH. Some users (like me) may not have it on the system PATH and normally don't have problems since an IDE like Webstorm configured with a node interpreter mostly runs tests and builds without any problem. However, this doesn't work with create-react-app because it expects node on the PATH.

Luckily, there is an easy way of getting an absolute path to the current interpreter binary so we can use it and remove the requirement that node is on the system PATH.

I have verified that before this change, running tests in Webstorm failed with this

'node' is not recognized as an internal or external command,
operable program or batch file.

while after the change, tests run.

I ran yarn run format which pulled in an unrelated file. Hope it's ok to update it so people don't keep on running into it when sending a change.

[facebook-github-bot]

Hi @anuraaga!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[anuraaga]

Hello - wonder if anyone has had a chance to take a look at this :)

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[anuraaga]

Hello - can anyone take a look at this? @iansu @ianschmitz ?

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[ianschmitz]

Thanks!