-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen eslint-config-react-app peer dependency versions #7790
Widen eslint-config-react-app peer dependency versions #7790
Conversation
I don't think we can roll out the import { useBasename } from 'history'
useBasename(); You could work around it like so: import { useBasename as withBasename } from 'history'
withBasename(); but this would still be a breaking change for existing apps. |
Is it possible to roll out a new major for this? Calling a hook at top level is potentially a bug anyway so I think it's a good idea to allow |
packages/react-scripts/fixtures/kitchensink/template/src/features/syntax/ArrayDestructuring.js
Show resolved
Hide resolved
Thanks! I updated the PR to focus on the flow plugin fix. The hooks plugin peer dependency is currently correct as we use version |
I decided to include the hooks peer dependency change as well, but we won't bump the actual plugin version here and will instead do it in next major of CRA. Sorry for the back and forth. |
Thanks! |
Close #7759
Description
From #7759, install
eslint-config-react-app
will produce a warning:They will be fixed by widening the peer dependency values for
eslint-plugin-flowtype
andeslint-plugin-react-hooks
to include the latest major.Acceptance criteria
eslint-plugin-flowtype
in this repo should be3.x || 4.x
.eslint-plugin-react-hooks
in this repo should be1.x || 2.x
.eslint-config-react-app
should not produce the warning above.