Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency major version upgrades #8950

Merged
merged 14 commits into from
May 13, 2020
Merged

Conversation

ianschmitz
Copy link
Contributor

@ianschmitz ianschmitz commented May 4, 2020

Bumps a number of dependencies that were out-of-date due to them dropping Node 8 support.

I ran Prettier over the repo as we've updated Prettier's major.

@sumanbh
Copy link

sumanbh commented May 4, 2020

If we update chalk, we'd need to update its usage here as well.

-new chalk.constructor({level: 1});
+new chalk.Instance({level: 1})

And wouldn't chalk >= 3 break IE11 again? See #8405

@ianschmitz ianschmitz requested a review from amyrlam as a code owner May 8, 2020 04:13
@ianschmitz ianschmitz merged commit f5c3bdb into facebook:master May 13, 2020
@ianschmitz ianschmitz deleted the upgrade-majors branch May 13, 2020 04:17
@matamatanot
Copy link

matamatanot commented May 13, 2020

@ianschmitz
Why were you able to upgrade chalk?
What about 5b80f55?

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants