Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump resolve-url-loader version #9841

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Conversation

johannespfeiffer
Copy link
Contributor

Currently, npm audit fails because of react-scripts > resolve-url-loader > adjust-sourcemap-loader > object-path.
See #9840 for details.

This PR bumps the resolve-url-loader version from 3.1.1 to 3.1.2

@facebook-github-bot
Copy link

Hi @johannespfeiffer!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@clementlecorre
Copy link

Up!

@kowalk
Copy link

kowalk commented Oct 20, 2020

UP

@zamaraevk
Copy link

+1 🙏

@the8thbit
Copy link

the8thbit commented Oct 20, 2020

only you can save us johannes

@dubis78
Copy link

dubis78 commented Oct 20, 2020

UP

@cchukuigwe
Copy link

+1

1 similar comment
@rscarson
Copy link

+1

@facebook facebook locked as too heated and limited conversation to collaborators Oct 20, 2020
@gaearon
Copy link
Contributor

gaearon commented Oct 20, 2020

The discussion is happening on the linked issue. You’re welcome to participate in it if you have something substantial to add. But spamming the thread with “+1”s makes it less likely to be merged soon, not more.

@gaearon gaearon merged commit 7965594 into facebook:master Oct 20, 2020
@gaearon
Copy link
Contributor

gaearon commented Oct 20, 2020

I've included this into [email protected] (but without the unpinning because I think we need to have CI fixed before we can risk unpinning in past majors).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.