Add executable gossip validation functions for capella - #5049
Merged
jtraglia merged 13 commits intoApr 22, 2026
Conversation
Member
Author
|
@nflaig if you have time to test, these are just the BTEC tests: reftests.zip [updated] Note: We can do the full capella test suite after the altair/bellatrix PRs are merged & rebased onto this branch. |
nflaig
reviewed
Mar 27, 2026
Member
looks good to me, passing all these tests |
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Apr 8, 2026
See ethereum/consensus-specs#5047 and ethereum/consensus-specs#5049 --------- Co-authored-by: Lodekeeper <258435968+lodekeeper@users.noreply.github.com> Co-authored-by: Cayman <caymannava@gmail.com>
jihoonsong
reviewed
Apr 22, 2026
jihoonsong
reviewed
Apr 22, 2026
This was referenced May 12, 2026
4 tasks
dapplion
pushed a commit
to dapplion/consensus-specs
that referenced
this pull request
May 19, 2026
Two upstream tests added by ethereum/consensus-specs PRs ethereum#5033 and ethereum#5049 assume Ethereum mainnet's larger default test state where validators are sparse across sync committee subnets. On the Gnosis (this fork's mainnet) preset the default state has 128 validators, exactly equal to the subcommittee size, so: - test_gossip_sync_committee_contribution_and_proof__reject_aggregator_not_in_subcommittee: no validator exists outside the subcommittee, so the negative mutation is a no-op and validation correctly returns valid. - test_gossip_sync_committee_message__reject_wrong_subnet: validators occupy all subnets, so every subnet is valid for them and there is no wrong subnet to pick. Detect both cases and return early with a comment, matching the precedent set by PR #3's adaptations (e.g. test_switch_to_compounding_requests_when_too_little_consolidation_churn_limit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds executable gossip message validation specs for Capella.