Document blob_sidecar in gossip validation format - #5267
Closed
apetro2 wants to merge 1 commit into
Closed
Conversation
Member
|
Hey @apetro2 thanks but this fix already exists in this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the networking gossip validation format documentation to include
blob_sidecaras a supported gossip topic and documented message type. This is necessary because Deneb-era executable gossip validation tests and helper mappings already useblob_sidecar, so without this update the format spec is incomplete and can mislead implementers who rely ontests/formats/networking/gossip_validation.mdas the source of truth.Checklist
make lintto check formattingmake testto check testsRelations
Related to #5146
Related to #5049