Merge preset files - #3
Closed
dapplion wants to merge 1 commit into
Closed
Conversation
dapplion
force-pushed
the
preset-single-file
branch
3 times, most recently
from
November 9, 2023 07:53
b9f2292 to
b66e587
Compare
dapplion
force-pushed
the
preset-single-file
branch
from
November 9, 2023 07:57
b66e587 to
c91d0dc
Compare
dapplion
pushed a commit
that referenced
this pull request
May 26, 2024
New consolidation tests, comments
dapplion
pushed a commit
that referenced
this pull request
May 19, 2026
Two upstream tests added by ethereum/consensus-specs PRs ethereum#5033 and ethereum#5049 assume Ethereum mainnet's larger default test state where validators are sparse across sync committee subnets. On the Gnosis (this fork's mainnet) preset the default state has 128 validators, exactly equal to the subcommittee size, so: - test_gossip_sync_committee_contribution_and_proof__reject_aggregator_not_in_subcommittee: no validator exists outside the subcommittee, so the negative mutation is a no-op and validation correctly returns valid. - test_gossip_sync_committee_message__reject_wrong_subnet: validators occupy all subnets, so every subnet is valid for them and there is no wrong subnet to pick. Detect both cases and return early with a comment, matching the precedent set by PR #3's adaptations (e.g. test_switch_to_compounding_requests_when_too_little_consolidation_churn_limit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preset in defined in multiple files, while the config is defined in one file. I couldn't find a good reason to keep the preset variables split in different files, and this PR should proof that the specs run just fine too. Having all preset variables in a single file should make it a bit simpler to manage them, no need to de-duplicate or parse multiple files.
Merging of the files is done with the script
Running two commands from the consensus-specs root dir
If mantainers want to verify that the merging is consistent and correct, they can run the script locally and check no git diff