Add executable gossip validation functions for bellatrix - #5047
Merged
jtraglia merged 10 commits intoApr 22, 2026
Conversation
Member
Author
|
@nflaig If you have time to test these out 😄 reftests.zip |
Member
yep passing all of these, after fixing one check we had missed |
nflaig
added a commit
to ChainSafe/lodestar
that referenced
this pull request
Apr 8, 2026
See ethereum/consensus-specs#5047 and ethereum/consensus-specs#5049 --------- Co-authored-by: Lodekeeper <258435968+lodekeeper@users.noreply.github.com> Co-authored-by: Cayman <caymannava@gmail.com>
jihoonsong
reviewed
Apr 22, 2026
jihoonsong
left a comment
jihoonsong
left a comment
Member
There was a problem hiding this comment.
Looks great! Left some comments on error messages but not super confident that they're better. Just wanted to make it more informative.
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds executable gossip message validation specs for Bellatrix.