Update the EIP-6366 by chiro-hiro · Pull Request #6618 · ethereum/EIPs

chiro-hiro · 2023-03-06T04:33:37Z

This a draft pull request, we will link to #6617 after a EIP number was assigned to Bit Based Permission.

eth-bot · 2023-03-06T04:34:10Z

All reviewers have approved. Auto merging...

* Change the order of parameters * Update eip-6366 to make it more clear * Link eip-6366 to eip-6617 * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update assets/eip-6366/example/APermissionToken.sol Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update example of permission token * Update missing indexed parameters and code format * Update following new style guide for reference ERC ethereum#6603 --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

chiro-hiro · 2023-03-14T15:35:00Z

@Pandapip1 Please help us review this.

chiro-hiro · 2023-03-15T12:48:26Z

@eth-bot rerun

* Update the EIP-6366 following suggest from vdusart and Pandapip1 * Feature/update eip 6366 (ethereum#10) * Change the order of parameters * Update eip-6366 to make it more clear * Link eip-6366 to eip-6617 * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update assets/eip-6366/example/APermissionToken.sol Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update example of permission token * Update missing indexed parameters and code format * Update following new style guide for reference ERC ethereum#6603 --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update the EIP-6366 following suggest from vdusart and Pandapip1 * Feature/update eip 6366 (#10) * Change the order of parameters * Update eip-6366 to make it more clear * Link eip-6366 to eip-6617 * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update assets/eip-6366/example/APermissionToken.sol Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update example of permission token * Update missing indexed parameters and code format * Update following new style guide for reference ERC ethereum#6603 --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

Update the EIP-6366 following suggest from vdusart and Pandapip1

6701344

github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-erc labels Mar 6, 2023

chiro-hiro marked this pull request as ready for review March 10, 2023 17:12

chiro-hiro requested a review from eth-bot as a code owner March 10, 2023 17:12

eth-bot enabled auto-merge (squash) March 15, 2023 12:49

eth-bot approved these changes Mar 15, 2023

View reviewed changes

eth-bot merged commit afd2c30 into ethereum:master Mar 15, 2023

chiro-hiro deleted the feature/eip-6366 branch March 15, 2023 17:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Update the EIP-6366#6618

Update the EIP-6366#6618
eth-bot merged 2 commits intoethereum:masterfrom
orochi-network:feature/eip-6366

chiro-hiro commented Mar 6, 2023 •

edited by github-actions bot

Loading

Uh oh!

eth-bot commented Mar 6, 2023

Uh oh!

chiro-hiro commented Mar 14, 2023

Uh oh!

chiro-hiro commented Mar 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

chiro-hiro commented Mar 6, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eth-bot commented Mar 6, 2023

Uh oh!

chiro-hiro commented Mar 14, 2023

Uh oh!

chiro-hiro commented Mar 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chiro-hiro commented Mar 6, 2023 •

edited by github-actions bot

Loading