Skip to content

Comments

Update EIP-1: Follow the style guide rules#6603

Merged
eth-bot merged 1 commit intoethereum:masterfrom
Amxx:fix/eip1
Mar 15, 2023
Merged

Update EIP-1: Follow the style guide rules#6603
eth-bot merged 1 commit intoethereum:masterfrom
Amxx:fix/eip1

Conversation

@Amxx
Copy link
Contributor

@Amxx Amxx commented Mar 3, 2023

As described in the style guide:

When referring to an EIP with a category of ERC, it must be written in the hyphenated form ERC-X where X is that EIP’s assigned number.

@Amxx Amxx requested a review from eth-bot as a code owner March 3, 2023 18:11
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Mar 3, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 3, 2023 •
edited
Loading

All reviewers have approved. Auto merging...

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Mar 3, 2023
Pandapip1
Pandapip1 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@Pandapip1 Pandapip1 changed the title Enforce the style guide rules Update EIP-1: Follow the style guide rules Mar 3, 2023
chiro-hiro added a commit to orochi-network/EIPs that referenced this pull request Mar 9, 2023
@chiro-hiro
Update following new style guide for reference ERC
5955931 
ethereum#6603
chiro-hiro added a commit to orochi-network/EIPs that referenced this pull request Mar 10, 2023
@chiro-hiro @vdusart
Feature/update eip 6366 (#10)
62d8b60 
* Change the order of parameters

* Update eip-6366 to make it more clear

* Link eip-6366 to eip-6617

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update assets/eip-6366/example/APermissionToken.sol

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update example of permission token

* Update missing indexed parameters and code format

* Update following new style guide for reference ERC
ethereum#6603

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
@eth-bot eth-bot enabled auto-merge (squash) March 15, 2023 01:39
@eth-bot eth-bot merged commit 39574f1 into ethereum:master Mar 15, 2023
eth-bot pushed a commit that referenced this pull request Mar 15, 2023
@chiro-hiro @vdusart
Update the EIP-6366 (#6618)
afd2c30 
* Update the EIP-6366 following suggest from vdusart and Pandapip1

* Feature/update eip 6366 (#10)

* Change the order of parameters

* Update eip-6366 to make it more clear

* Link eip-6366 to eip-6617

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update assets/eip-6366/example/APermissionToken.sol

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update example of permission token

* Update missing indexed parameters and code format

* Update following new style guide for reference ERC
#6603

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
@Amxx Amxx deleted the fix/eip1 branch March 15, 2023 20:38
axelcabee pushed a commit to axelcabee/EIPs that referenced this pull request May 6, 2023
@Amxx @axelcabee
Enforce the style guide rules (ethereum#6603)
b142ed4
axelcabee pushed a commit to axelcabee/EIPs that referenced this pull request May 6, 2023
@chiro-hiro @vdusart @axelcabee
Update the EIP-6366 (ethereum#6618)
31d73a9 
* Update the EIP-6366 following suggest from vdusart and Pandapip1

* Feature/update eip 6366 (ethereum#10)

* Change the order of parameters

* Update eip-6366 to make it more clear

* Link eip-6366 to eip-6617

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update assets/eip-6366/example/APermissionToken.sol

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update example of permission token

* Update missing indexed parameters and code format

* Update following new style guide for reference ERC
ethereum#6603

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@Amxx @GAEAlimited
Enforce the style guide rules (ethereum#6603)
fea7bdc
GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request Jun 19, 2024
@chiro-hiro @vdusart @GAEAlimited
Update the EIP-6366 (ethereum#6618)
7f614f9 
* Update the EIP-6366 following suggest from vdusart and Pandapip1

* Feature/update eip 6366 (#10)

* Change the order of parameters

* Update eip-6366 to make it more clear

* Link eip-6366 to eip-6617

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-6366.md

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update assets/eip-6366/example/APermissionToken.sol

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update example of permission token

* Update missing indexed parameters and code format

* Update following new style guide for reference ERC
ethereum#6603

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamWilsn SamWilsn SamWilsn approved these changes

@eth-bot eth-bot eth-bot approved these changes

@axic axic Awaiting requested review from axic

@lightclient lightclient Awaiting requested review from lightclient

+1 more reviewer

@Pandapip1 Pandapip1 Pandapip1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c-update Modifies an existing proposal e-consensus Waiting on editor consensus t-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Amxx @eth-bot @Pandapip1 @SamWilsn