Add EIP-6617: Add a new bit based permission proposal#6617

Merged

eth-bot merged 15 commits intoethereum:masterfrom

orochi-network:feature/bit_based_permission

Mar 9, 2023

Contributor

chiro-hiro commented Mar 6, 2023

No description provided.


          Add a new bit based permission proposal

26c183d

Co-authored-by: Chiro Hiro <chiro8x@gmail.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

chiro-hiro requested a review from eth-bot as a code owner

March 6, 2023 04:11

github-actions bot added s-draft t-erc labels

Collaborator

eth-bot commented Mar 6, 2023 •

edited

Loading

All reviewers have approved. Auto merging...

eth-bot added e-consensus e-review labels

github-actions bot added the w-ci label

Contributor Author

chiro-hiro commented Mar 6, 2023

We add a new Bit Based Permission proposal as your request. I and @vdusart will update EIP-6366 as well.

chiro-hiro mentioned this pull request

Update the EIP-6366 #6618

Merged

Contributor

abcoathup commented Mar 6, 2023

The PR doesn't have a c-new label?

Pandapip1 suggested changes

View reviewed changes

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

EIPS/eip-bit_based_permission.md Outdated


		The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174.

		_Note_ The following specifications use syntax from Solidity `0.8.7` (or above)

Member

Pandapip1 Mar 6, 2023

This doesn't include any solidity. I think you forgot to include the interface.

Contributor Author

chiro-hiro Mar 7, 2023

@vdusart implemented a library to perform bit wise operators

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

EIPS/eip-bit_based_permission.md Outdated

+              With the `256` bits of the `uint256`, we can create up to `256` differents permissions which leads to `2²⁵⁶` unique combinaisons also called roles.
+              *(A role is a combination of multiple permissions).* All roles don't have to be predefined.
+              Since permissions are defined as powers of two, we can use the `OR` operator to create new role based on multiple permissions.

Member

Pandapip1 Mar 6, 2023

Suggested change

      
            Since permissions are defined as powers of two, we can use the `OR` operator to create new role based on multiple permissions.
          
            Since permissions are defined as unsigned integers, we can use the binary OR operator to create new role based on multiple permissions.

Contributor

vdusart Mar 9, 2023

👍

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

EIPS/eip-bit_based_permission.md Outdated

+              ## Motivation
+              Currently permission and access control are done using `string` or `keccak256(string)` comparaisons (see [ERC-5982](./eip-5982.md)).
+              By using bitwise and bitmask operations to determine access rights, we gain in efficiency, flexibility and more.

Member

Pandapip1 Mar 6, 2023

Suggested change

      
            By using bitwise and bitmask operations to determine access rights, we gain in efficiency, flexibility and more.

This reads like Rationale.

EIPS/eip-bit_based_permission.md Outdated Show resolved Hide resolved

vdusart and others added 2 commits

March 6, 2023 15:15


          Update EIPS/eip-bit_based_permission.md

090d17b

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-bit_based_permission.md

8892fa2

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

github-actions bot added c-new and removed w-ci labels

vdusart and others added 4 commits

March 6, 2023 15:16


          Update EIPS/eip-bit_based_permission.md

2814c2d

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-bit_based_permission.md

155799f

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-bit_based_permission.md

a19fc74

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-bit_based_permission.md

58955d0

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

github-actions bot added the w-ci label


          Add suggestions (#9)

55acc91

github-actions bot removed the w-ci label

Pandapip1 changed the title ~~Add a new bit based permission proposal~~ Add EIP-6617: Add a new bit based permission proposal

Pandapip1 suggested changes

View reviewed changes

EIPS/eip-6617.md Outdated Show resolved Hide resolved

EIPS/eip-6617.md Outdated Show resolved Hide resolved

EIPS/eip-6617.md Outdated Show resolved Hide resolved

EIPS/eip-6617.md Show resolved Hide resolved

EIPS/eip-6617.md Outdated Show resolved Hide resolved

vdusart and others added 5 commits

March 9, 2023 01:13


          Update EIPS/eip-6617.md

d05abf6

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-6617.md

175e1cc

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-6617.md

f56029e

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-6617.md

fecbba1

Co-authored-by: Gavin John <gavinnjohn@gmail.com>


          Update EIPS/eip-6617.md

775c356

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

github-actions bot commented Mar 9, 2023

The commit 775c356 (as a parent of 2eb7729) contains errors.
Please inspect the Run Summary for details.

github-actions bot added the w-ci label


          fix typos and CI/CD

2e14b66

github-actions bot removed the w-ci label

chiro-hiro commented

View reviewed changes

EIPS/eip-6617.md Outdated

+                  /**
+                      @notice Add permission
+                      @param _permission          The given permission
+                      @param _permissionToAdd		The permission that will be added

Contributor Author

chiro-hiro Mar 9, 2023

@vdusart I think, code formatter is broken.


          formatting

23d7837

Pandapip1 approved these changes

View reviewed changes

Member

Pandapip1 left a comment

Lgtm for draft

eth-bot enabled auto-merge (squash)

March 9, 2023 13:39

eth-bot approved these changes

View reviewed changes

eth-bot merged commit 511b961 into ethereum:master

chiro-hiro deleted the feature/bit_based_permission branch

March 10, 2023 05:34

fulldecent pushed a commit to fulldecent/EIPs that referenced this pull request


          Add EIP-6617: Add a new bit based permission proposal (ethereum#6617)

98b2ccb

* Add a new bit based permission proposal

Co-authored-by: Chiro Hiro <chiro8x@gmail.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Add suggestions (ethereum#9)

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* fix typos and CI/CD

* formatting

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Gavin John <gavinnjohn@gmail.com>
Co-authored-by: Victor DUSART <dusartvictor@gmail.com>

axelcabee pushed a commit to axelcabee/EIPs that referenced this pull request


          Add EIP-6617: Add a new bit based permission proposal (ethereum#6617)

87e134c

* Add a new bit based permission proposal

Co-authored-by: Chiro Hiro <chiro8x@gmail.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Add suggestions (ethereum#9)

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* fix typos and CI/CD

* formatting

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Gavin John <gavinnjohn@gmail.com>
Co-authored-by: Victor DUSART <dusartvictor@gmail.com>

GAEAlimited pushed a commit to GAEAlimited/EIPs that referenced this pull request


          Add EIP-6617: Add a new bit based permission proposal (ethereum#6617)

ef4172d

* Add a new bit based permission proposal

Co-authored-by: Chiro Hiro <chiro8x@gmail.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-bit_based_permission.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Add suggestions (#9)

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* Update EIPS/eip-6617.md

Co-authored-by: Gavin John <gavinnjohn@gmail.com>

* fix typos and CI/CD

* formatting

---------

Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Gavin John <gavinnjohn@gmail.com>
Co-authored-by: Victor DUSART <dusartvictor@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-new e-consensus e-review s-draft t-erc