Merged
Conversation
vdusart
suggested changes
Mar 9, 2023
vdusart
left a comment
vdusart
left a comment
There was a problem hiding this comment.
I left a lot of small grammar corrections but I agree with the rest !
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
|
The commit 5955931 (as a parent of 0c6f9f1) contains errors. |
vdusart
approved these changes
Mar 9, 2023
chiro-hiro
added a commit
that referenced
this pull request
Mar 24, 2023
* Update the EIP-6366 following suggest from vdusart and Pandapip1 * Feature/update eip 6366 (#10) * Change the order of parameters * Update eip-6366 to make it more clear * Link eip-6366 to eip-6617 * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update EIPS/eip-6366.md Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update assets/eip-6366/example/APermissionToken.sol Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> * Update example of permission token * Update missing indexed parameters and code format * Update following new style guide for reference ERC ethereum#6603 --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com> --------- Co-authored-by: Victor Dusart <43795504+vdusart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.