feat(hardhat-ovm): allow overriding the polling interval#646
Closed
feat(hardhat-ovm): allow overriding the polling interval#646
Conversation
🦋 Changeset detectedLatest commit: 326ed41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ider and its signers The default is 50ms, which should make running the OVM tests smooth. If you want to run tests against a remote node and do not want to overwhelm it, set the parameter in the hardhat config's network
gakonst
force-pushed
the
feat/hh-interval
branch
from
aee0a5f to
326ed41
Compare
Contributor
Author
|
This PR seems to be causing an error in #641 which I haven't digested yet. Converted to draft, will have this ready for review/merge tomorrow. |
Contributor
Author
|
Closing, moving it over to 641. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ethers by default uses a polling interval of [4s](https://github.com/ethers-io/ethers.js/blob/3b1d3fcee6bfb5178861e26ff1a1e9daa0663ec9/packages/providers/src.ts/base-provider.ts#L513 for its asynchronous promises runner. This is too long when used with the Optimistic Ethereum stack.
In order to override that setting, we can set the
provider.pollingIntervalto a smaller value, allowing us to reduce the total time wasted when sleeping.The interval now defaults to 50ms, which should make running the OVM tests smooth. If you want
to run tests against a remote node and do not want to overwhelm it, you can set the parameter in the hardhat config's network, e.g.