Skip to content

op-program: Implement wrapper methods required by derive.Engine#5364

Merged
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-derive-engine
Apr 6, 2023
Merged

op-program: Implement wrapper methods required by derive.Engine#5364
OptimismBot merged 2 commits intodevelopfrom
aj/fpp-derive-engine

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Apr 6, 2023

Description

Implement wrapper methods required by derive.Engine. This is pretty much just sugar over the existing backend methods, performing some additional conversions.

Adds flags to specify the l2 execution genesis and agreed l2 starting head.

Additional context

Builds on #5361

Metadata

@ajsutton ajsutton requested a review from a team as a code owner April 6, 2023 05:44
@ajsutton ajsutton requested review from mslipper and removed request for a team April 6, 2023 05:44
@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2023

⚠️ No Changeset found

Latest commit: ed4adee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #5364 (96cbdb8) into develop (6edd990) will decrease coverage by 0.15%.
The diff coverage is 57.54%.

❗ Current head 96cbdb8 differs from pull request most recent head ed4adee. Consider uploading reports for the commit ed4adee to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5364      +/-   ##
===========================================
- Coverage    38.44%   38.30%   -0.15%     
===========================================
  Files          342      243      -99     
  Lines        24921    22112    -2809     
  Branches       597        0     -597     
===========================================
- Hits          9581     8469    -1112     
+ Misses       14533    12860    -1673     
+ Partials       807      783      -24     
Flag Coverage Δ
bedrock-go-tests 38.30% <57.54%> (+0.22%) ⬆️
common-ts-tests ?
contracts-bedrock-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-program/cmd/main.go 68.85% <0.00%> (ø)
op-program/l2/l2.go 0.00% <0.00%> (ø)
op-program/l2/engine.go 66.07% <66.07%> (ø)
op-program/config/config.go 100.00% <100.00%> (ø)
op-program/flags/flags.go 100.00% <100.00%> (ø)

... and 106 files with indirect coverage changes

@ajsutton ajsutton force-pushed the aj/fpp-derive-engine branch from 9377617 to d4309fb Compare April 6, 2023 06:56
Adds flags to specify the l2 execution genesis and agreed l2 starting head.
@ajsutton ajsutton force-pushed the aj/fpp-derive-engine branch from d4309fb to 96cbdb8 Compare April 6, 2023 07:04
Base automatically changed from aj/fpp-engine to develop April 6, 2023 13:13
@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This PR has been added to the merge queue, and will be merged soon.

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit ed4adee
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642ec829970c980008305fd7

@mergify
Copy link
Contributor

mergify bot commented Apr 6, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit a7fd5bd into develop Apr 6, 2023
@OptimismBot OptimismBot deleted the aj/fpp-derive-engine branch April 6, 2023 16:27
@mergify mergify bot removed the on-merge-train label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants