ci: make slither not fail CI

[tynes]

Description

slither is halting CI. It thinks that yul is an antipattern. It is blocking PRs from being merged because of a if (boolean == false) check which is completely sane, sure you can do if (!boolean) but that is less readable. This commit prevents slither from halting CI. We can figure out how much we want to use slither in the future.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9950b40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for opstack-docs canceled.

Name	Link
🔨 Latest commit	9950b40
🔍 Latest deploy log	https://app.netlify.com/sites/opstack-docs/deploys/642f551706c4fd0008aa1c2e

[trianglesphere]

Slither is passing on develop. Is there a specific PR which is causing it to fail?

[tynes]

Slither is passing on develop. Is there a specific PR which is causing it to fail?

There are a bunch of PRs, see #5356
The reason it is failing incredibly lame and not helpful

[clabby]

Slither is passing on develop. Is there a specific PR which is causing it to fail?

There are a bunch of PRs, see #5356 The reason it is failing incredibly lame and not helpful

This does look annoying, feels like something a linter should do rather than Slither. The suggestion does look like a valid lint, tho.

To break it down:

• !boolValue compiles to 2 bytes of asm:

DUP<N>  // [bool]
ISZERO  // [not_bool]

• boolValue == false compiles to 4 bytes of asm:

DUP<N>     // [bool]
PUSH1 0x00 // [false, bool]
EQ         // [bool == false]

The optimizer picks this up in the non-IR pipeline most of the time, though.

[trianglesphere]

Approving b/c @maurelian approved.

[mergify]

This PR has been added to the merge queue, and will be merged soon.

[mergify]

This PR is next in line to be merged, and will be merged as soon as checks pass.

[maurelian]

I had a second thought, will update shortly

[refcell]

This was fixed in #5356 by excluding boolean_equality in slither's config file at slither.config.json#L2, correct @tynes?