Skip to content

feat(ctb): Add doOwnershipTransfer to deploy utils#5354

Merged
maurelian merged 2 commits intodevelopfrom
jm/streamline-migration/doProxyTransfer
Apr 5, 2023
Merged

feat(ctb): Add doOwnershipTransfer to deploy utils#5354
maurelian merged 2 commits intodevelopfrom
jm/streamline-migration/doProxyTransfer

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Apr 5, 2023

  1. Creates a reusable function doOwnershipTransfer which deduplicates the logic for transferring ownership of the 4 system contracts to the MSD.
  2. Combines the awaitCondition call for each of those transfers into a single call at the end. This provides better support for a multicall based transfer, by printing out all the info required to create a batch of transactions at once. It also still supports a 'one at a time' transfer approach, as it will check all contracts before progressing.

@maurelian maurelian requested a review from a team as a code owner April 5, 2023 17:53
@maurelian maurelian requested review from smartcontracts and removed request for a team April 5, 2023 17:53
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

⚠️ No Changeset found

Latest commit: 79706a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@maurelian maurelian force-pushed the jm/streamline-migration/doProxyTransfer branch from f1ae368 to 79706a9 Compare April 5, 2023 18:11
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5354 (79706a9) into jm/streamline-migration/script-cleanup (153e578) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##           jm/streamline-migration/script-cleanup    #5354   +/-   ##
=======================================================================
  Coverage                                   38.73%   38.73%           
=======================================================================
  Files                                         361      361           
  Lines                                       25174    25174           
  Branches                                      668      668           
=======================================================================
+ Hits                                         9750     9751    +1     
- Misses                                      14643    14644    +1     
+ Partials                                      781      779    -2     
Flag Coverage Δ
bedrock-go-tests 35.50% <ø> (+<0.01%) ⬆️
contracts-bedrock-tests 51.20% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, good work

Base automatically changed from jm/streamline-migration/script-cleanup to develop April 5, 2023 19:00
@maurelian maurelian merged commit cb8fbc4 into develop Apr 5, 2023
@maurelian maurelian deleted the jm/streamline-migration/doProxyTransfer branch April 5, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants