Skip to content

fix(ctb): Update hardhat.json to fix hh deploy#5352

Merged
OptimismBot merged 4 commits intodevelopfrom
jm/streamline-migration/phase1
Apr 5, 2023
Merged

fix(ctb): Update hardhat.json to fix hh deploy#5352
OptimismBot merged 4 commits intodevelopfrom
jm/streamline-migration/phase1

Conversation

@maurelian
Copy link
Contributor

Adds a phase1() methods to the MSD which consolidates the various stepN() methods into two groups.

This is the first PR in a series that will significantly reduce the number of multisig transactions which need to be executed.

I tested this primarily by running the deploy scripts locally.

npx hardhat deploy --tags setup,phase1,phase2

Missing values were causing a type error, which prevented
running the basic 'npx hardhat deploy` script.
@maurelian maurelian requested a review from a team as a code owner April 5, 2023 16:17
@maurelian maurelian requested a review from tynes April 5, 2023 16:17
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

⚠️ No Changeset found

Latest commit: 459f98c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 459f98c
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642db95a0b1b1e00084fa8f6

@tynes
Copy link
Contributor

tynes commented Apr 5, 2023

contracts/deployment/SystemDictator.sol

║ Line     │ Column   │ Type     │ Message                                                │ Rule ID              ║
╟──────────┼──────────┼──────────┼────────────────────────────────────────────────────────┼──────────────────────╢
║ 206      │ 5        │ warning  │ Function order is incorrect, external  function        │ ordering             ║
║          │          │          │ can not go after public  function (line 193)           │                      ║
║ 420      │ 1        │ error    │ Insert ⏎                                               │ prettier/prettier    ║

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me given the linting is fixed

Copy link
Contributor Author

maurelian commented Apr 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@maurelian maurelian force-pushed the jm/streamline-migration/phase1 branch from 44cc77c to 8e76fac Compare April 5, 2023 16:50
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5352 (459f98c) into develop (46a7b66) will decrease coverage by 2.94%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5352      +/-   ##
===========================================
- Coverage    39.04%   36.10%   -2.94%     
===========================================
  Files          383      292      -91     
  Lines        25952    22468    -3484     
  Branches       801      179     -622     
===========================================
- Hits         10132     8112    -2020     
+ Misses       15041    13577    -1464     
  Partials       779      779              
Flag Coverage Δ
bedrock-go-tests 35.52% <ø> (+0.01%) ⬆️
common-ts-tests ?
contracts-bedrock-tests 51.20% <0.00%> (-0.13%) ⬇️
contracts-tests ?
core-utils-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts-bedrock/contracts/deployment/SystemDictator.sol 0.00% <0.00%> (ø)

... and 93 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit 694f3ea into develop Apr 5, 2023
@OptimismBot OptimismBot deleted the jm/streamline-migration/phase1 branch April 5, 2023 18:28
@mergify mergify bot removed the on-merge-train label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants