Skip to content

Migration script clean up#5353

Merged
maurelian merged 2 commits intodevelopfrom
jm/streamline-migration/script-cleanup
Apr 5, 2023
Merged

Migration script clean up#5353
maurelian merged 2 commits intodevelopfrom
jm/streamline-migration/script-cleanup

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Apr 5, 2023

Minor changes that clean up the logging in the deploy scripts.

@maurelian maurelian requested a review from a team as a code owner April 5, 2023 16:46
@maurelian maurelian requested review from clabby and removed request for a team April 5, 2023 16:46
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

⚠️ No Changeset found

Latest commit: 153e578

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

maurelian commented Apr 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@maurelian maurelian force-pushed the jm/streamline-migration/phase1 branch from 44cc77c to 8e76fac Compare April 5, 2023 16:50
@maurelian maurelian force-pushed the jm/streamline-migration/script-cleanup branch 2 times, most recently from c71d790 to 75bace9 Compare April 5, 2023 16:51
@maurelian maurelian force-pushed the jm/streamline-migration/script-cleanup branch from 75bace9 to 153e578 Compare April 5, 2023 17:32
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #5353 (153e578) into jm/streamline-migration/phase1 (8e76fac) will increase coverage by 1.84%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                        Coverage Diff                         @@
##           jm/streamline-migration/phase1    #5353      +/-   ##
==================================================================
+ Coverage                           36.88%   38.73%   +1.84%     
==================================================================
  Files                                 360      361       +1     
  Lines                               25137    25174      +37     
  Branches                              668      668              
==================================================================
+ Hits                                 9271     9750     +479     
+ Misses                              15110    14643     -467     
- Partials                              756      781      +25     
Flag Coverage Δ
bedrock-go-tests 35.50% <ø> (+2.15%) ⬆️
contracts-bedrock-tests 51.20% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
dtl-tests 47.15% <ø> (ø)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@maurelian maurelian force-pushed the jm/streamline-migration/phase1 branch from 334f195 to 8e76fac Compare April 5, 2023 17:53
Base automatically changed from jm/streamline-migration/phase1 to develop April 5, 2023 18:28
@maurelian maurelian merged commit 653ca9d into develop Apr 5, 2023
@maurelian maurelian deleted the jm/streamline-migration/script-cleanup branch April 5, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants