contracts-bedrock: upgrade script for post sherlock#5292
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
LGTM- Double checked the versions and addresses for the goerli implementations / proxies and checks out. Agree w/ @refcell that approvals should be in memory, but given that it's a script I don't mind if we keep it as is. Deferring to @maurelian for explicit approval.
Includes a complete upgrade script that can be ran
for upgrading any op-stack based chain that was deployed
before the sherlock audit fixes were all included.
The script is ran with the following command:
```bash
forge script \
scripts/upgrades/PostSherlock.s.sol \
--rpc-url $ETH_RPC_URL \
--private-key $PRIVATE_KEY \
--sig 'run(address,address)' \
$SAFE_ADDRESS \
$PROXY_ADMIN_ADDRESS
```
Signers should run the script and be sure to add any required
flags so that hardware wallets can be used. The script will
submit a single transaction that approves the upgrade and
then checks to see if there have been enough approvals and
then triggers the upgrade if there have been enough approvals.
This comes with test coverage but requires a goerli RPC url.
To run the tests, use the following command:
```bash
forge test --contracts scripts/upgrades --rpc-url $ETH_RPC_URL
```
Co-authored-by: clabby <ben@clab.by>
tynes
force-pushed
the
feat/sherlock-upgrade
branch
from
baef049 to
dd22a77
Compare
|
Something is wrong with the cache in CI, getting disk corruption errors. Am currently running the integration test build locally to debug |
Revert "Merge pull request #5292 from ethereum-optimism/feat/sherlock-upgrade"
…sherlock-upgrade"" This reverts commit cc4f526.
…sherlock-upgrade"" This reverts commit cc4f526.
3 participants
Description
Includes a complete upgrade script that can be ran for upgrading any op-stack based chain that was deployed before the sherlock audit fixes were all included.
The script is ran with the following command:
forge script \ scripts/upgrades/PostSherlock.s.sol \ --rpc-url $ETH_RPC_URL \ --private-key $PRIVATE_KEY \ --sig 'run(address,address)' \ $SAFE_ADDRESS \ $PROXY_ADMIN_ADDRESSSigners should run the script and be sure to add any required flags so that hardware wallets can be used. The script will submit a single transaction that approves the upgrade and then checks to see if there have been enough approvals and then triggers the upgrade if there have been enough approvals.
This comes with test coverage but requires a goerli RPC url. To run the tests, use the following command: