Skip to content

Revert "Merge pull request #5292 from ethereum-optimism/feat/sherlock-upgrade"#5320

Merged
mergify[bot] merged 1 commit intodevelopfrom
jg/fix_ci
Mar 31, 2023
Merged

Revert "Merge pull request #5292 from ethereum-optimism/feat/sherlock-upgrade"#5320
mergify[bot] merged 1 commit intodevelopfrom
jg/fix_ci

Conversation

@trianglesphere
Copy link
Contributor

@trianglesphere trianglesphere commented Mar 31, 2023

This reverts commit b315cda, reversing changes made to f738fcf. This reverts PR #5292 because it broke the build.

…-upgrade"

This reverts commit b315cda, reversing
changes made to f738fcf.
@trianglesphere trianglesphere requested a review from a team as a code owner March 31, 2023 17:33
@trianglesphere trianglesphere requested a review from clabby March 31, 2023 17:33
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

⚠️ No Changeset found

Latest commit: cc4f526

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere requested a review from mslipper March 31, 2023 17:33
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit cc4f526
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6427197b4c6bf900082fd7fc

@trianglesphere trianglesphere requested review from tynes and removed request for clabby March 31, 2023 17:33
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #5320 (cc4f526) into develop (2fc8ed4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5320      +/-   ##
===========================================
- Coverage    39.93%   39.93%   -0.01%     
===========================================
  Files          350      382      +32     
  Lines        22822    24376    +1554     
  Branches       492      838     +346     
===========================================
+ Hits          9115     9734     +619     
- Misses       12978    13911     +933     
- Partials       729      731       +2     
Flag Coverage Δ
bedrock-go-tests 36.20% <ø> (-0.01%) ⬇️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 51.32% <ø> (ø)
contracts-tests 98.86% <ø> (ø)
core-utils-tests 60.41% <ø> (ø)
dtl-tests 47.15% <ø> (?)
fault-detector-tests 33.88% <ø> (ø)
sdk-tests 38.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 33 files with indirect coverage changes

@tynes
Copy link
Contributor

tynes commented Mar 31, 2023

This builds fine on my local machine? Is something up with the way that caching works?

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
This code has served it's purpose, so while it's important from a historical perspective, it's not entirely necessary to have it on develop event.

@mergify mergify bot merged commit 7354398 into develop Mar 31, 2023
@mergify mergify bot deleted the jg/fix_ci branch March 31, 2023 18:01
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants