Skip to content

fix(ctb): Use git hashes to specify deps in package.json#5318

Closed
maurelian wants to merge 1 commit intodevelopfrom
jm/git-hashes-not-versions
Closed

fix(ctb): Use git hashes to specify deps in package.json#5318
maurelian wants to merge 1 commit intodevelopfrom
jm/git-hashes-not-versions

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Mar 31, 2023

Description

#5292 seems to have introduced an issue with package installation.
Maybe this fixes it, we'll see.

@maurelian maurelian requested a review from a team as a code owner March 31, 2023 17:09
@maurelian maurelian requested a review from tynes March 31, 2023 17:09
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8aa7be0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 31, 2023 •
edited
Loading

✅ Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 8aa7be0
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/642717627494560008f68f73

@maurelian maurelian force-pushed the jm/git-hashes-not-versions branch from 2125499 to 8aa7be0 Compare March 31, 2023 17:24
trianglesphere
trianglesphere reviewed Mar 31, 2023
View reviewed changes
packages/contracts-bedrock/package.json
"hardhat-deploy": "^0.11.4",
"@safe-global/safe-contracts": "https://github.com/safe-global/safe-contracts.git#v1.3.0-libs.0",
"solady": "https://github.com/Vectorized/solady.git#v0.0.85",
"@safe-global/safe-contracts": "https://github.com/safe-global/safe-contracts.git#cb4b2b19b3e336b8defd3b8c9e0e6a2ae130598c",
Copy link
Contributor

@trianglesphere trianglesphere Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to fully remove the .git suffix.

Copy link
Contributor Author

@maurelian maurelian Mar 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was previously working on other packages (ie. forge-std above), but I'll give it a shot.

@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Mar 31, 2023
@maurelian
Copy link
Contributor Author

maurelian commented Mar 31, 2023

Superceded by 5320

@maurelian maurelian closed this Mar 31, 2023
@mergify mergify bot removed the conflict label Mar 31, 2023
@maurelian maurelian deleted the jm/git-hashes-not-versions branch February 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes Awaiting requested review from tynes tynes is a code owner automatically assigned from ethereum-optimism/contract-reviewers

1 more reviewer

@trianglesphere trianglesphere trianglesphere left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maurelian @trianglesphere