ctp: Remove ERC721Refunded events#3522
Merged
mergify[bot] merged 2 commits intodevelopfrom Sep 22, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 60ba0e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
approved these changes
Sep 21, 2022
maurelian
commented
Sep 21, 2022
smartcontracts
approved these changes
Sep 22, 2022
tynes
approved these changes
Sep 22, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
mslipper
pushed a commit
that referenced
this pull request
Sep 22, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies branching logic in the ERC721 bridge by removing the
ERC20Refundedevent.This has the downside of making it slightly more difficult for indexers to differentiate between a transfer from Bob to Alice vs. a refund resulting from a failed transfer from Alice to Bob. However:
ERC721BridgeFailedevent.Tests
I removed a couple tests that became redundant after removing this functionality.
Additional context
Yay for code deletion.