Conversation
|
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
|
Added a commit that re-orders the |
packages/contracts-periphery/contracts/universal/op-erc721/ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
L-13: Refactors a lot of the functionality in the NFT bridges into a single base contract.
M-08: Fixes upgradeability inconsistencies in the ERC721 bridge contracts.
The third commit replaces
CrossDomainEnabledwithCrossDomainMessengerin the ERC721 bridge contracts becauseCrossDomainEnabledis not upgradeable.The fourth commit makes
otherBridgeandmessengerin the NFT bridge contracts immutable as requested here.