Skip to content

Comments

nft: N-08 Easily bypass-able requirement#3493

Merged
mergify[bot] merged 3 commits intodevelopfrom
ctp/n-08
Sep 16, 2022
Merged

nft: N-08 Easily bypass-able requirement#3493
mergify[bot] merged 3 commits intodevelopfrom
ctp/n-08

Conversation

@sam-goldman
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: c8c1d00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tynes
Copy link
Contributor

tynes commented Sep 15, 2022

It feels like we could dedupe this by putting it into the base contract natspec and then using @inheritdoc

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added conflict and removed on-merge-train labels Sep 15, 2022
@mergify mergify bot removed the conflict label Sep 16, 2022
@sam-goldman
Copy link
Contributor Author

It feels like we could dedupe this by putting it into the base contract natspec and then using @inheritdoc

Did that in #3491

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 9bb9fb2 into develop Sep 16, 2022
@mergify mergify bot deleted the ctp/n-08 branch September 16, 2022 00:33
@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants