nft: N-11 Unused inherited contract#3459
nft: N-11 Unused inherited contract#3459sam-goldman wants to merge 3 commits intoethereum-optimism:developfrom
Conversation
|
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
| @@ -89,9 +87,6 @@ contract L1ERC721Bridge is Semver, CrossDomainEnabled, OwnableUpgradeable { | |||
| function initialize(address _messenger, address _otherBridge) public initializer { | |||
| messenger = _messenger; | |||
| otherBridge = _otherBridge; | |||
There was a problem hiding this comment.
It would be cheaper and more consistent with the direction of our StandardBridge to make this an immutable variable.
There was a problem hiding this comment.
Are you referring to messenger, otherBridge, or both?
There was a problem hiding this comment.
Changed this in this PR, where it seemed more in scope.
| @@ -52,9 +50,6 @@ contract OptimismMintableERC721Factory is Semver, OwnableUpgradeable { | |||
| function initialize(address _bridge, uint256 _remoteChainId) public initializer { | |||
| bridge = _bridge; | |||
| remoteChainId = _remoteChainId; | |||
There was a problem hiding this comment.
Interesting, what's this used for?
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
Left some comments. Generally LGTM once CI is working.
|
Closed by #3489. |
2 participants
Removes unused
OwnableUpgradeableimport in NFT bridge contracts. Also removes this import inOptimismMintableERC721Factory, which is not mentioned in this finding, but the import is unused nonetheless.