Skip to content

chore: Update op-geth to latest version#3524

Merged
mergify[bot] merged 2 commits intodevelopfrom
chore/update-geth
Sep 22, 2022
Merged

chore: Update op-geth to latest version#3524
mergify[bot] merged 2 commits intodevelopfrom
chore/update-geth

Conversation

@mslipper
Copy link
Contributor

@mslipper mslipper commented Sep 21, 2022

Update op-geth to the latest version on the optimism-history branch. This version exposes the customizable simulator backend that we need to merge #3322.

Also adds a small script to automatically update the op-geth version in the future.

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2022

⚠️ No Changeset found

Latest commit: ebc91c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the chore/update-geth branch 2 times, most recently from 9f3a23e to f1b33dc Compare September 21, 2022 23:23
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one double import, but overall looking good. Having the script is super nice rather than doing it by hand.

@mslipper
Copy link
Contributor Author

Tests will run once CircleCI fixes its outage.

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.work also contains a reference to op-geth. The script should include that too.

@github-actions github-actions bot added the A-op-bindings Area: op-bindings label Sep 22, 2022
@github-actions github-actions bot removed the A-op-bindings Area: op-bindings label Sep 22, 2022
Update op-geth to the latest version on the `optimism-history` branch. This version exposes the customizable simulator backend that we need to merge #3322.
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This PR has been added to the merge queue, and will be merged soon.

Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much of this tooling will we get to delete if we are using tags rather than commit hashes/branches?

@mergify mergify bot removed the on-merge-train label Sep 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This PR has been added to the merge queue, and will be merged soon.

@mslipper
Copy link
Contributor Author

How much of this tooling will we get to delete if we are using tags rather than commit hashes/branches?

The bit that resolves the branch to the pseudo-version in the updater script. We'll still need the rest.

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 1bbce92 into develop Sep 22, 2022
@mergify mergify bot deleted the chore/update-geth branch September 22, 2022 18:38
@mergify mergify bot removed the on-merge-train label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants