Merged
Conversation
The `contracts` tests included a test that did a deep equality check against two bignumbers. This check stopped working due to changes in the bignumber implementations used, two bignumbers of the same number no longer were considered equal. This commit fixes that problem by using the same version of ethers as `hardhat` and also stringifying the results so that strings are compared instead of objects. This fixes the broken tests.
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
contractstests included a test that did a deep equality checkagainst two bignumbers. This check stopped working due to changes
in the bignumber implementations used, two bignumbers of the same number
no longer were considered equal. This commit fixes that problem by
using the same version of ethers as
hardhatand also stringifyingthe results so that strings are compared instead of objects. This
fixes the broken tests.