Skip to content

contracts: fix broken contracts tests #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tynes merged 1 commit into from
Jun 8, 2022
Merged

contracts: fix broken contracts tests #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/contracts/test/helpers/test-runner/json-test-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
/* External Imports */
import { ethers } from 'hardhat'
import { Contract, BigNumber } from 'ethers'
import { Contract } from 'ethers'

import { expect } from '../../setup'

const bigNumberify = (arr: any[]) => {
return arr.map((el: any) => {
if (typeof el === 'number') {
return BigNumber.from(el)
return ethers.BigNumber.from(el)
} else if (typeof el === 'string' && /^\d+n$/gm.test(el)) {
return BigNumber.from(el.slice(0, el.length - 1))
return ethers.BigNumber.from(el.slice(0, el.length - 1))
} else if (typeof el === 'string' && el.length > 2 && el.startsWith('0x')) {
return BigNumber.from(el.toLowerCase())
return ethers.BigNumber.from(el.toLowerCase())
} else if (Array.isArray(el)) {
return bigNumberify(el)
} else {
Expand All @@ -34,9 +34,10 @@ export const runJsonTest = (contractName: string, json: any): void => {
await expect(contract.functions[functionName](...test.in)).to.be
.reverted
} else {
expect(
bigNumberify(await contract.functions[functionName](...test.in))
).to.deep.equal(bigNumberify(test.out))
const result = await contract.functions[functionName](...test.in)
expect(JSON.stringify(bigNumberify(result))).to.deep.equal(
JSON.stringify(bigNumberify(test.out))
)
}
})
}
Expand Down