feat: nft bridge from l1 to optimism#2662
Merged
tynes merged 14 commits intoethereum-optimism:developfrom Jun 13, 2022
sam-goldman:feat/nft-bridge
Merged
feat: nft bridge from l1 to optimism#2662tynes merged 14 commits intoethereum-optimism:developfrom sam-goldman:feat/nft-bridge
tynes merged 14 commits intoethereum-optimism:developfrom
sam-goldman:feat/nft-bridge
Conversation
🦋 Changeset detectedLatest commit: f6a932d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
C-protocol-critical
tynes
reviewed
Jun 2, 2022
github-actions
bot
added
A-op-bindings
Contributor
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/contracts/L2/messaging/L2StandardERC721Factory.sol
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/contracts/L2/messaging/L2StandardERC721Factory.sol
Show resolved
Hide resolved
Contributor
|
It looks like something is wrong with the build, a rebase on |
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/L1/messaging/L1ERC721Bridge.spec.ts
Outdated
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/L1/messaging/L1ERC721Bridge.spec.ts
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/L1/messaging/L1ERC721Bridge.spec.ts
Outdated
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/L1/messaging/L1ERC721Bridge.spec.ts
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/standards/L2StandardERC721.spec.ts
Show resolved
Hide resolved
tynes
reviewed
Jun 6, 2022
packages/contracts-periphery/test/contracts/L2/messaging/L2ERC721Bridge.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
|
I think generally adding coverage for events that are emitted would be great :) |
Contributor
|
Hmm not sure why the contracts tests decided to fail here, will investigate |
tynes
reviewed
Jun 8, 2022
Contributor
|
Q: Are there any deployment script written for this yet (or other periphery contracts for that matter)? Also, it looks like the upgrade proxy is still needed here? |
Contributor
|
Hey @sam-goldman! This PR has merge conflicts. Please fix them before continuing review. |
tynes
approved these changes
Jun 8, 2022
packages/contracts-periphery/test/contracts/L2/messaging/L2StandardERC721Factory.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
|
I opened #2727 to fix the broken contracts tests |
maurelian
reviewed
Jun 9, 2022
packages/contracts-periphery/contracts/L2/messaging/L2StandardERC721Factory.sol
Show resolved
Hide resolved
packages/contracts-periphery/contracts/L1/messaging/L1ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/L2/messaging/L2ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/L2/messaging/L2ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/L1/messaging/L1ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
maurelian
reviewed
Jun 9, 2022
Contributor
|
If you rebase on top of latest |
Contributor
Author
|
Added the deploy scripts! |
maurelian
reviewed
Jun 10, 2022
Contributor
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
Looking solid.
One comment.
maurelian
approved these changes
Jun 13, 2022
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Closes #2662 The `ReorgTask` already contains the logic for verifying the consistency. I'm reusing it at startup by calling the `handle_l1_reorg` when initializing the l1 watcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An ERC721 bridge between Mainnet and Optimism. The issue describing the bridge can be found here.