Closed
Conversation
Change link to say withdrawal spec rather than deposit spec, when it really goes to withdrawals.md Instead of ethereum-optimism/optimistic-specs#448
|
| If the caller is a contract, the address will be transformed by adding | ||
| `0x1111000000000000000000000000000000001111` to it. This is the reverse of the | ||
| transformation described in the [deposits spec](./withdrawals.md#address-aliasing). This prevents attacks in which a | ||
| transformation described in the [withdrawal spec](./withdrawals.md#address-aliasing). This prevents attacks in which a |
Contributor
There was a problem hiding this comment.
Actually, TODO, we don't do aliasing on the way back.
Contributor
|
Being fixed in #2658 (ToB also called this out). |
Contributor
|
Hey @qbzzt! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This PR implements a comprehensive spellcheck workflow using the `typos` tool, following the same approach as [paradigmxyz/reth#17501](paradigmxyz/reth#17501). ## Changes **GitHub Actions Integration:** - Added `typos` job to existing `rust_ci.yaml` workflow - Runs on all PRs with 30-minute timeout **Configuration (`typos.toml`):** - Excludes build artifacts, git files, and generated content - Excludes `*.go` files - Allows project-specific terminology (kona, asterisc, cannon, superchain, etc.) **Local Development Support:** - Added `just lint-typos` target for local spell checking with **Codebase Cleanup:** - Fixed all existing typos throughout the codebase (15 files affected) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: emhane <58548332+emhane@users.noreply.github.com> Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Emilia Hane <undefined@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change link to say withdrawal spec rather than deposit spec, when it really goes to withdrawals.md
Instead of ethereum-optimism/optimistic-specs#448