Skip to content

op-bindings: bedrock go bindings#2571

Merged
mergify[bot] merged 1 commit intodevelopfrom
bedrock-bindings
May 17, 2022
Merged

op-bindings: bedrock go bindings#2571
mergify[bot] merged 1 commit intodevelopfrom
bedrock-bindings

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented May 17, 2022

Mirrors ethereum-optimism/optimistic-specs#446, but squashed and with adjustments to integrate it into the monorepo CI.

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

⚠️ No Changeset found

Latest commit: cbb0c66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from cfromknecht and mslipper May 17, 2022 00:59
@mergify
Copy link
Contributor

mergify bot commented May 17, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda
Copy link
Contributor Author

protolambda commented May 17, 2022

Looks like abigen isn't available in the solidity CI job that checks the go bindings. Can we include that in the base ethereumoptimism/go-builder image, or is it fine to install it during CI?

@mslipper
Copy link
Collaborator

mslipper commented May 17, 2022 •
edited
Loading

I'll include abigen in the CI builder. Will have that ready this evening.

@mergify
Copy link
Contributor

mergify bot commented May 17, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit a655fea into develop May 17, 2022
@mergify mergify bot deleted the bedrock-bindings branch May 17, 2022 01:20
@mergify
Copy link
Contributor

mergify bot commented May 17, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

theochap added a commit that referenced this pull request Dec 10, 2025
@theochap @clabby
patch(node/conductor): patch conductor bootstrap (#2589)
48b03ad 
## Description

Close #2571

---------

Co-authored-by: clabby <ben@clab.by>
theochap added a commit that referenced this pull request Jan 14, 2026
@theochap @clabby
patch(node/conductor): patch conductor bootstrap (op-rs/kona#2589)
574278b 
## Description

Close #2571

---------

Co-authored-by: clabby <ben@clab.by>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@Inphi Inphi Inphi approved these changes

@cfromknecht cfromknecht Awaiting requested review from cfromknecht

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@protolambda @mslipper @Inphi