This repository was archived by the owner on Jan 16, 2026. It is now read-only.
patch(node/conductor): patch conductor bootstrap#2589
Merged
Conversation
theochap
requested review from
clabby,
dhyaniarun1993,
emhane,
itschaindev,
refcell and
sadiq1971
as code owners
theochap
added
K-feature
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the sync start RPC functionality for the node conductor by addressing an issue where the engine unsafe head was zeroed out before syncing. The fix retrieves the unsafe head from the L1 safe head when the node hasn't synced yet and isn't connected to an external sequencer.
Key changes:
- Added logic to detect and handle zeroed unsafe head in engine queries
- Created a new constructor for
EngineSyncStateto facilitate state updates - Added a new test configuration for conductor functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/node/engine/src/query.rs |
Added sync start fix by checking for zeroed unsafe head and retrieving forkchoice state from L1 |
crates/node/engine/src/state/core.rs |
Added new constructor for EngineSyncState to support state initialization |
tests/devnets/first-kona-conductor.yaml |
Added new test configuration for conductor functionality with multiple sequencers |
.github/workflows/e2e_tests.yaml |
Added the new conductor test configuration to the CI pipeline |
Comments suppressed due to low confidence (1)
crates/node/engine/src/query.rs:92
- [nitpick] The field name
un_safeis inconsistent with typical Rust naming conventions. Consider usingunsafe_headorunsafe_blockfor clarity.
forkchoice_state.un_safe,
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clabby
force-pushed
the
theo/patch-sync-status
branch
from
4062ea7 to
ba4eaf2
Compare
## Overview Allows for the sequencer to catch up by building the next block immediately if the next L2 block timestamp is > the block time away from the system time.
clabby
approved these changes
Jul 30, 2025
theochap
force-pushed
the
theo/patch-sync-status
branch
from
9bf4ade to
bbbb151
Compare
theochap
force-pushed
the
theo/patch-sync-status
branch
from
bbbb151 to
e4cb236
Compare
theochap
changed the title
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
## Description Close op-rs/kona#2571 --------- Co-authored-by: clabby <ben@clab.by>
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
## Description Close #2571 --------- Co-authored-by: clabby <ben@clab.by>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #2571