This repository was archived by the owner on Jan 24, 2024. It is now read-only.
op-bindings: separate bindings into new module to resolve dependency cycle#446
Merged
op-bindings: separate bindings into new module to resolve dependency cycle#446
Conversation
protolambda
force-pushed
the
bindings-module
branch
from
60166e6 to
82b5107
Compare
Codecov Report
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 52.59% 52.28% -0.31%
==========================================
Files 70 70
Lines 7855 7855
==========================================
- Hits 4131 4107 -24
- Misses 3176 3197 +21
- Partials 548 551 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
protolambda
changed the title
This was referenced May 16, 2022
tynes
approved these changes
May 17, 2022
mslipper
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate the contract bindings into a new go module.
This fixes a cyclic dependency where
op-nodewould import bindings fromop-proposer, whileop-proposerimports types fromop-node.This also simplifies the build system nicely: there's one place and one makefile to use when contracts change.
Edit: also did some
go mod tidying: the geth version we pull in with thereplaceis v1.10.17+ already, but therequirewas still on 1.10.16Since the bindings are all generated code I did not include this new module in the coverage reporting CI. (And we don't use all of the bindings anyway)