Skip to content

maint(ct): clean up L2StdTokenFac tests #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Apr 24, 2022
Merged

maint(ct): clean up L2StdTokenFac tests #2492

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2a714a
maint(ct): clean up L2StdTokenFac tests
smartcontracts Apr 16, 2022
170aa1f
Merge branch 'develop' into sc/ct-test-cleanup-12
mergify[bot] Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions packages/contracts/test/contracts/L2/messaging/L2StandardTokenFactory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,23 @@
/* External Imports */
import { ethers } from 'hardhat'
import { Signer, ContractFactory, Contract } from 'ethers'
import { ContractFactory, Contract } from 'ethers'
import {
smock,
MockContractFactory,
MockContract,
} from '@defi-wonderland/smock'

/* Internal Imports */
import { expect } from '../../../setup'
import { predeploys, getContractInterface } from '../../../../src'
import { deploy } from '../../../helpers'
import { predeploys } from '../../../../src'

describe('L2StandardTokenFactory', () => {
let signer: Signer
let Factory__L1ERC20: MockContractFactory<ContractFactory>
let L1ERC20: MockContract<Contract>
let L2StandardTokenFactory: Contract
before(async () => {
;[signer] = await ethers.getSigners()
// deploy an ERC20 contract on L1
Factory__L1ERC20 = await smock.mock(
'@openzeppelin/contracts/token/ERC20/ERC20.sol:ERC20'
)
Factory__L1ERC20 = await smock.mock('ERC20')
L1ERC20 = await Factory__L1ERC20.deploy('L1ERC20', 'ERC')

L2StandardTokenFactory = await (
await ethers.getContractFactory('L2StandardTokenFactory')
).deploy()
L2StandardTokenFactory = await deploy('L2StandardTokenFactory')
})

describe('Standard token factory', () => {
Expand All @@ -36,18 +27,18 @@ describe('L2StandardTokenFactory', () => {
'L2ERC20',
'ERC'
)

// Pull the token creation event from the receipt
const receipt = await tx.wait()
const [tokenCreatedEvent] = receipt.events
const tokenCreatedEvent = receipt.events[0]

// Expect there to be an event emmited for the standard token creation
// Expect there to be an event emitted for the standard token creation
expect(tokenCreatedEvent.event).to.be.eq('StandardL2TokenCreated')

// Get the L2 token address from the emmited event and check it was created correctly
const l2TokenAddress = tokenCreatedEvent.args._l2Token
const l2Token = new Contract(
l2TokenAddress,
getContractInterface('L2StandardERC20'),
signer
// Get the L2 token address from the emitted event and check it was created correctly
const l2Token = await ethers.getContractAt(
'L2StandardERC20',
tokenCreatedEvent.args._l2Token
)

expect(await l2Token.l2Bridge()).to.equal(predeploys.L2StandardBridge)
Expand Down