Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/yellow-pandas-help.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@eth-optimism/sdk': patch
---

Fixes a bug where the wrong Overrides type was being used for gas estimation functions
15 changes: 11 additions & 4 deletions packages/sdk/src/adapters/standard-bridge.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
import { ethers, Contract, Overrides, Signer, BigNumber } from 'ethers'
import {
ethers,
Contract,
Overrides,
Signer,
BigNumber,
CallOverrides,
} from 'ethers'
import {
TransactionRequest,
TransactionResponse,
Expand Down Expand Up @@ -350,7 +357,7 @@ export class StandardBridgeAdapter implements IBridgeAdapter {
l2Token: AddressLike,
amount: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.messenger.l1Provider.estimateGas(
Expand All @@ -365,7 +372,7 @@ export class StandardBridgeAdapter implements IBridgeAdapter {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.messenger.l1Provider.estimateGas(
Expand All @@ -379,7 +386,7 @@ export class StandardBridgeAdapter implements IBridgeAdapter {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.messenger.l2Provider.estimateGas(
Expand Down
18 changes: 9 additions & 9 deletions packages/sdk/src/cross-chain-messenger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
TransactionRequest,
} from '@ethersproject/abstract-provider'
import { Signer } from '@ethersproject/abstract-signer'
import { ethers, BigNumber, Overrides } from 'ethers'
import { ethers, BigNumber, Overrides, CallOverrides } from 'ethers'
import { sleep, remove0x } from '@eth-optimism/core-utils'
import { predeploys } from '@eth-optimism/contracts'

Expand Down Expand Up @@ -1128,7 +1128,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
message: CrossChainMessageRequest,
opts?: {
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
const tx = await this.populateTransaction.sendMessage(message, opts)
Expand All @@ -1143,7 +1143,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
message: MessageLike,
messageGasLimit: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l1Provider.estimateGas(
Expand All @@ -1158,7 +1158,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
finalizeMessage: async (
message: MessageLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l1Provider.estimateGas(
Expand All @@ -1171,7 +1171,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l1Provider.estimateGas(
Expand All @@ -1183,7 +1183,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l2Provider.estimateGas(
Expand All @@ -1196,7 +1196,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
l2Token: AddressLike,
amount: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l1Provider.estimateGas(
Expand All @@ -1216,7 +1216,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l1Provider.estimateGas(
Expand All @@ -1235,7 +1235,7 @@ export class CrossChainMessenger implements ICrossChainMessenger {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber> => {
return this.l2Provider.estimateGas(
Expand Down
8 changes: 4 additions & 4 deletions packages/sdk/src/interfaces/bridge-adapter.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Contract, Overrides, Signer, BigNumber } from 'ethers'
import { Contract, Overrides, Signer, BigNumber, CallOverrides } from 'ethers'
import {
TransactionRequest,
TransactionResponse,
Expand Down Expand Up @@ -250,7 +250,7 @@ export interface IBridgeAdapter {
l2Token: AddressLike,
amount: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -273,7 +273,7 @@ export interface IBridgeAdapter {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -294,7 +294,7 @@ export interface IBridgeAdapter {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>
}
Expand Down
18 changes: 9 additions & 9 deletions packages/sdk/src/interfaces/cross-chain-messenger.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Event, BigNumber, Overrides } from 'ethers'
import { Event, BigNumber, Overrides, CallOverrides } from 'ethers'
import {
Provider,
BlockTag,
Expand Down Expand Up @@ -697,7 +697,7 @@ export interface ICrossChainMessenger {
message: CrossChainMessageRequest,
opts?: {
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
) => Promise<BigNumber>

Expand All @@ -714,7 +714,7 @@ export interface ICrossChainMessenger {
message: MessageLike,
messageGasLimit: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -729,7 +729,7 @@ export interface ICrossChainMessenger {
finalizeMessage(
message: MessageLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -748,7 +748,7 @@ export interface ICrossChainMessenger {
l2Token: AddressLike,
amount: NumberLike,
opts?: {
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -767,7 +767,7 @@ export interface ICrossChainMessenger {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -784,7 +784,7 @@ export interface ICrossChainMessenger {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -807,7 +807,7 @@ export interface ICrossChainMessenger {
opts?: {
recipient?: AddressLike
l2GasLimit?: NumberLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>

Expand All @@ -828,7 +828,7 @@ export interface ICrossChainMessenger {
amount: NumberLike,
opts?: {
recipient?: AddressLike
overrides?: Overrides
overrides?: CallOverrides
}
): Promise<BigNumber>
}
Expand Down