Skip to content

fix(ct): use default hardhat accounts#2426

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/ct-robust-hh-fund
Apr 11, 2022
Merged

fix(ct): use default hardhat accounts#2426
mergify[bot] merged 2 commits intodevelopfrom
sc/ct-robust-hh-fund

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Apr 5, 2022

Description
Uses the default configuration for the hardhat network, including the
accounts. We no longer need to use custom accounts (to be honest, I
don't remember why we ever needed that in the first place). Making this
change also fixes the problem where deployment to the hardhat network
would fail because the hardhat accounts did not have a balance.

Fixes #2419

@smartcontracts
fix(ct): use default hardhat accounts
9e80c46 
Uses the default configuration for the hardhat network, including the
accounts. We no longer need to use custom accounts (to be honest, I
don't remember why we ever needed that in the first place). Making this
change also fixes the problem where deployment to the hardhat network
would fail because the hardhat accounts did not have a balance.

Fixes #2419
@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2003ba8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly April 5, 2022 20:06
@tynes
Copy link
Contributor

tynes commented Apr 5, 2022 •
edited
Loading

I like the approach in #2422 because that would allow us to use geth or any node that exposes eth_accounts as the L1 node and have it just work

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Apr 5, 2022

I like the approach in #2422 because that would allow us to use geth or any node that exposes eth_accounts as the L1 node and have it just work

Honestly I think we should make a small project out of overhauling this step anyway. I don't think it belongs as part of the deployment. It's specifically meant for local development and could likely be handled as an extra task. The reason #2422 didn't work is because we supply a specific private key when running npx hardhat deploy and getSigners() only returns an array of length 1. I prefer this as a temporary fix and then the "real" fix is to change how we do this funding step entirely.

@tynes
Copy link
Contributor

tynes commented Apr 5, 2022

It could be moved to a hardhat task pretty easily and we could add that as part of the deployer entrypoint

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Apr 5, 2022

Exactly, yeah. This is more of a temp fix to close #2419 and then we can make a second PR to turn into a hardhat task.

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 11, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit b2a3239 into develop Apr 11, 2022
@mergify mergify bot deleted the sc/ct-robust-hh-fund branch April 11, 2022 15:56
@mslipper mslipper mentioned this pull request Apr 12, 2022
Merged
nebojsa94 pushed a commit to Tenderly/optimism that referenced this pull request Apr 26, 2022
@smartcontracts @mergify @nebojsa94
fix(ct): use default hardhat accounts (ethereum-optimism#2426)
9d7a4be 
Uses the default configuration for the hardhat network, including the
accounts. We no longer need to use custom accounts (to be honest, I
don't remember why we ever needed that in the first place). Making this
change also fixes the problem where deployment to the hardhat network
would fail because the hardhat accounts did not have a balance.

Fixes ethereum-optimism#2419

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
@PoulavBhowmick03 @emhane @dhyaniarun1993
chore (supervisor/types): change OutputV0 to camelCase (#2426)
7abac22 
Fixes #2418

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@Inphi Inphi Awaiting requested review from Inphi

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

+1 more reviewer

@cfromknecht cfromknecht cfromknecht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Last deploy task fails on Hardhat

3 participants

@smartcontracts @tynes @cfromknecht