fix(ct): make funding step of deploy more robust#2422
Closed
smartcontracts wants to merge 1 commit intodevelopfrom
Closed
fix(ct): make funding step of deploy more robust#2422smartcontracts wants to merge 1 commit intodevelopfrom
smartcontracts wants to merge 1 commit intodevelopfrom
Conversation
Tweaks the funding step of the deployment process to make it a bit more robust against situations where different accounts are used to start up the hardhat node. Current funding step made the assumption that the accounts being used were the default hardhat accounts, but the hardhat config within the contracts repo actually uses different accounts. It's working fine right now since we actually deploy the contracts using an entirely different hardhat config (the one found within ops/docker/hardhat/hardhat.config.js) which *does* use the default hardhat accounts. Fixes #2419
|
Inphi
approved these changes
Apr 5, 2022
mslipper
approved these changes
Apr 5, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
Author
|
There's a bug in this PR, need to fix |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
## Overview Cleans up the engine task logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tweaks the funding step of the deployment process to make it a bit more
robust against situations where different accounts are used to start up
the hardhat node. Current funding step made the assumption that the
accounts being used were the default hardhat accounts, but the hardhat
config within the contracts repo actually uses different accounts. It's
working fine right now since we actually deploy the contracts using an
entirely different hardhat config (the one found within
ops/docker/hardhat/hardhat.config.js) which does use the default
hardhat accounts.
Fixes #2419