[Low priority] Fix a bunch of nits in sdk#2418
Merged
mergify[bot] merged 4 commits intodevelopfrom Apr 5, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 2570e1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
roninjin10
changed the title
Contributor
smartcontracts
left a comment
smartcontracts
left a comment
There was a problem hiding this comment.
Looks good! One nit, then can approve
roninjin10
commented
Apr 5, 2022
smartcontracts
approved these changes
Apr 5, 2022
smartcontracts
approved these changes
Apr 5, 2022
Contributor
|
Needs a changeset, then LGTM. |
added 3 commits
April 5, 2022 14:00
chain id enum nit more utils nits fix the rest of the nits fix comment being moved remove comment that is no longer needed
mslipper
approved these changes
Apr 5, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
* Fix a bunch of nits chain id enum nit more utils nits fix the rest of the nits fix comment being moved remove comment that is no longer needed * add comment to isL2Provider so jsdocs works and change comment * yarn changeset Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
* Fix a bunch of nits chain id enum nit more utils nits fix the rest of the nits fix comment being moved remove comment that is no longer needed * add comment to isL2Provider so jsdocs works and change comment * yarn changeset Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Fixes #2418 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
Fixes #2418 --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I explored the sdk via reading all the code and fixing nits as I saw them. I didn't see very many. The code did a really good job of not trying to be clever and just being very straight forward and simple.
as constit shows the actual constant value as the type when you hover which I always find nice.Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata