Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

chore (supervisor/types): change OutputV0 to camelCase#2426

Merged
dhyaniarun1993 merged 6 commits intoop-rs:mainfrom
PoulavBhowmick03:change/OutputV0/camelCase
Aug 26, 2025
Merged

chore (supervisor/types): change OutputV0 to camelCase#2426
dhyaniarun1993 merged 6 commits intoop-rs:mainfrom
PoulavBhowmick03:change/OutputV0/camelCase

Conversation

@PoulavBhowmick03
Copy link
Contributor

@PoulavBhowmick03 PoulavBhowmick03 commented Jul 17, 2025

Fixes #2418

@PoulavBhowmick03 PoulavBhowmick03 changed the title change OutputV0 to camelCase chore (supervisor/types): change OutputV0 to camelCase Jul 17, 2025
@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.9%. Comparing base (643dd49) to head (81c04fb).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dhyaniarun1993
Copy link
Collaborator

dhyaniarun1993 commented Jul 17, 2025

Please don't merge this until optimism release new docker images.

dhyaniarun1993
dhyaniarun1993 suggested changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@dhyaniarun1993 dhyaniarun1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good.
Please don't merge this until op release new docker images that contains the change. I am requesting the change to block the merging of the PR for now.

refcell
refcell previously requested changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a roundtrip serialization test and this is gtg. Thanks!

@refcell refcell added the M-do-not-merge Meta: Do not merge label Jul 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2025

This pull request has been automatically marked as stale because it has been inactive for 3 weeks.
It will be closed in 1 week if no further activity occurs.
If you believe this PR should remain open, please add the M-prevent-stale label or leave a comment.

@emhane emhane removed the M-stale label Aug 18, 2025
@dhyaniarun1993 dhyaniarun1993 removed the M-do-not-merge Meta: Do not merge label Aug 26, 2025
@dhyaniarun1993
Copy link
Collaborator

dhyaniarun1993 commented Aug 26, 2025

There is still no new release on the optimism. Since we need the changes in sysgo test as well, we have switched to the docker image tag develop in kurtosis to make sure this change is supported.

@dhyaniarun1993 dhyaniarun1993 requested a review from refcell August 26, 2025 11:39
@dhyaniarun1993 dhyaniarun1993 added this pull request to the merge queue Aug 26, 2025
Merged via the queue into op-rs:main with commit 7abac22 Aug 26, 2025
36 checks passed
theochap pushed a commit that referenced this pull request Aug 26, 2025
@PoulavBhowmick03 @emhane
@dhyaniarun1993 @theochap
chore (supervisor/types): change OutputV0 to camelCase (#2426)
9c5f20d 
Fixes #2418

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
@PoulavBhowmick03 @emhane @dhyaniarun1993
chore (supervisor/types): change OutputV0 to camelCase (op-rs/kona#2426)
1d952f3 
Fixes op-rs/kona#2418

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
@PoulavBhowmick03 @emhane @dhyaniarun1993
chore (supervisor/types): change OutputV0 to camelCase (op-rs/kona#2426)
c925846 
Fixes #2418

---------

Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itschaindev itschaindev Awaiting requested review from itschaindev

@sadiq1971 sadiq1971 Awaiting requested review from sadiq1971

@clabby clabby Awaiting requested review from clabby

@theochap theochap Awaiting requested review from theochap theochap is a code owner

@refcell refcell Awaiting requested review from refcell

2 more reviewers

@dhyaniarun1993 dhyaniarun1993 dhyaniarun1993 approved these changes

@emhane emhane emhane approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore (supervisor/types): change OutputV0 to camelCase

4 participants

@PoulavBhowmick03 @dhyaniarun1993 @refcell @emhane