Conversation
🦋 Changeset detectedLatest commit: b37354a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
fix/get-block-range
branch
from
0b7d338 to
f895c9c
Compare
|
Is there any way we could unit test this? And are we sure that the this new behavior doesn't break any implied contracts? Even though this is technically a bug, it's possible that the DTL or other downstream callers relied on the broken error handling. |
|
Unit tests wouldn't catch a downstream service hitting this error, what would happen is the dtl would index a |
tynes
force-pushed
the
fix/get-block-range
branch
from
f895c9c to
0450d08
Compare
|
I've pushed a new commit that returns a custom error |
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
… build task to reuse the insert task (#2399) ## Description This PR does the following cleanups to the engine tasks: - Use explicit error types instead of `dyn Box<...>` for the `EngineTaskError`. The goal of this is twofold: - Improve the composability of engine tasks (and be able to do some control flow when an engine task emits an error) - Allows explicit testing of the error cases (in the future when we'll add tests for the engine tasks) - Refactors the build task in the engine to reuse the `InsertUnsafe` task logic. This task is now called `InsertTask` to also encapsulate the case where we insert a derived block. Close #2390. Progress towards #2389
… build task to reuse the insert task (op-rs/kona#2399) ## Description This PR does the following cleanups to the engine tasks: - Use explicit error types instead of `dyn Box<...>` for the `EngineTaskError`. The goal of this is twofold: - Improve the composability of engine tasks (and be able to do some control flow when an engine task emits an error) - Allows explicit testing of the error cases (in the future when we'll add tests for the engine tasks) - Refactors the build task in the engine to reuse the `InsertUnsafe` task logic. This task is now called `InsertTask` to also encapsulate the case where we insert a derived block. Close #2390. Progress towards #2389
5 participants
Description
Fix for
eth_getBlockRangewhen an item is not found