This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Conversation
theochap
added
K-chore
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theochap
force-pushed
the
theo/engine-cleanups
branch
from
8f7ebc3 to
7737a4c
Compare
clabby
approved these changes
Jul 15, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
I'm quite happy with this refactor as-is - not too many comments with it being what we spoke about last week. Nice work, happy to see a more re-usable set of tasks :)
clabby
reviewed
Jul 15, 2025
| @@ -1,18 +1,20 @@ | |||
| //! Contains the error types for the [InsertUnsafeTask]. | |||
| //! Contains the error types for the [InsertTask]. | |||
Contributor
There was a problem hiding this comment.
While we're in here, let's change this over to [InsertTask] and in other cases (note backticks.)
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
… build task to reuse the insert task (op-rs/kona#2399) ## Description This PR does the following cleanups to the engine tasks: - Use explicit error types instead of `dyn Box<...>` for the `EngineTaskError`. The goal of this is twofold: - Improve the composability of engine tasks (and be able to do some control flow when an engine task emits an error) - Allows explicit testing of the error cases (in the future when we'll add tests for the engine tasks) - Refactors the build task in the engine to reuse the `InsertUnsafe` task logic. This task is now called `InsertTask` to also encapsulate the case where we insert a derived block. Close op-rs/kona#2390. Progress towards op-rs/kona#2389
theochap
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
… build task to reuse the insert task (op-rs/kona#2399) ## Description This PR does the following cleanups to the engine tasks: - Use explicit error types instead of `dyn Box<...>` for the `EngineTaskError`. The goal of this is twofold: - Improve the composability of engine tasks (and be able to do some control flow when an engine task emits an error) - Allows explicit testing of the error cases (in the future when we'll add tests for the engine tasks) - Refactors the build task in the engine to reuse the `InsertUnsafe` task logic. This task is now called `InsertTask` to also encapsulate the case where we insert a derived block. Close #2390. Progress towards #2389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following cleanups to the engine tasks:
dyn Box<...>for theEngineTaskError. The goal of this is twofold:InsertUnsafetask logic. This task is now calledInsertTaskto also encapsulate the case where we insert a derived block.Close #2390. Progress towards #2389