Infra update, kovan replica dtl version to 0.5.24#2399
Merged
mergify[bot] merged 2 commits intodevelopfrom Apr 1, 2022
Merged
Conversation
|
mslipper
approved these changes
Apr 1, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
…2399) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
… build task to reuse the insert task (#2399) ## Description This PR does the following cleanups to the engine tasks: - Use explicit error types instead of `dyn Box<...>` for the `EngineTaskError`. The goal of this is twofold: - Improve the composability of engine tasks (and be able to do some control flow when an engine task emits an error) - Allows explicit testing of the error cases (in the future when we'll add tests for the engine tasks) - Refactors the build task in the engine to reuse the `InsertUnsafe` task logic. This task is now called `InsertTask` to also encapsulate the case where we insert a derived block. Close #2390. Progress towards #2389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Also