This repository was archived by the owner on Jan 16, 2026. It is now read-only.
test (supervisor/rpc): supervisor_finalizedL1 and supervisor_superRootAtTimestamp#2395
Merged
itschaindev merged 5 commits intomainfrom Jul 11, 2025
Merged
test (supervisor/rpc): supervisor_finalizedL1 and supervisor_superRootAtTimestamp#2395itschaindev merged 5 commits intomainfrom
supervisor_finalizedL1 and supervisor_superRootAtTimestamp#2395itschaindev merged 5 commits intomainfrom
Conversation
itschaindev
requested review from
clabby,
dhyaniarun1993,
emhane,
refcell,
sadiq1971 and
theochap
as code owners
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sadiq1971
reviewed
Jul 11, 2025
sadiq1971
reviewed
Jul 11, 2025
sadiq1971
approved these changes
Jul 11, 2025
theochap
pushed a commit
that referenced
this pull request
Jul 15, 2025
…RootAtTimestamp` (#2395) Closes #2383 , #2384 - Skipped testing for `supervisor_syncStatus` because that is being tested checking the chain progress. - Skipped `supervisor_dependencySetV1` because we need `QueryAPI` in Go implementation to implement the end-point so that we can test it using devstack. #### Changes - The serialize and deserialize implemented for `ChainID` is now generic for `u64` because I needed it at other places as well. - Due to the way Go unmarshalls the response, I needed to add the response objects `SuperRootOutputRpc` and `ChainRootInfoRpc`, which are essentially the same as `SuperRootOutput` and `ChainRootInfo` used before. The fields `timestamp`, `version` and `chainID` needed to be compatible with `hexutil.Uint64` and hexutil.Bytes`. Hence all the modifications. Tested locally, all tests including e2e tests are passing as expected.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
…RootAtTimestamp` (op-rs/kona#2395) Closes op-rs/kona#2383 , op-rs/kona#2384 - Skipped testing for `supervisor_syncStatus` because that is being tested checking the chain progress. - Skipped `supervisor_dependencySetV1` because we need `QueryAPI` in Go implementation to implement the end-point so that we can test it using devstack. #### Changes - The serialize and deserialize implemented for `ChainID` is now generic for `u64` because I needed it at other places as well. - Due to the way Go unmarshalls the response, I needed to add the response objects `SuperRootOutputRpc` and `ChainRootInfoRpc`, which are essentially the same as `SuperRootOutput` and `ChainRootInfo` used before. The fields `timestamp`, `version` and `chainID` needed to be compatible with `hexutil.Uint64` and hexutil.Bytes`. Hence all the modifications. Tested locally, all tests including e2e tests are passing as expected.
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
…RootAtTimestamp` (op-rs/kona#2395) Closes #2383 , #2384 - Skipped testing for `supervisor_syncStatus` because that is being tested checking the chain progress. - Skipped `supervisor_dependencySetV1` because we need `QueryAPI` in Go implementation to implement the end-point so that we can test it using devstack. #### Changes - The serialize and deserialize implemented for `ChainID` is now generic for `u64` because I needed it at other places as well. - Due to the way Go unmarshalls the response, I needed to add the response objects `SuperRootOutputRpc` and `ChainRootInfoRpc`, which are essentially the same as `SuperRootOutput` and `ChainRootInfo` used before. The fields `timestamp`, `version` and `chainID` needed to be compatible with `hexutil.Uint64` and hexutil.Bytes`. Hence all the modifications. Tested locally, all tests including e2e tests are passing as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2383 , #2384
supervisor_syncStatusbecause that is being tested checking the chain progress.supervisor_dependencySetV1because we needQueryAPIin Go implementation to implement the end-point so that we can test it using devstack.Changes
ChainIDis now generic foru64because I needed it at other places as well.SuperRootOutputRpcandChainRootInfoRpc, which are essentially the same asSuperRootOutputandChainRootInfoused before. The fieldstimestamp,versionandchainIDneeded to be compatible withhexutil.Uint64and hexutil.Bytes`. Hence all the modifications.Tested locally, all tests including e2e tests are passing as expected.