op-challenger: Remove TraceType and just use GameType.

[ajsutton]

Description
Remove TraceType and just use GameType.

Rename --trace-type to --game-types with an alias to preserve backwards compatibility.

Each trace type already directly maps to a GameType and the concept of a "trace" only exists for fault dispute games.

Tests

Mostly covered by existing tests with a couple added to ensure GameType has a suitable String() implementation and that the --trace-type alias works correctly.

Additional context

Builds on #18432

Metadata

#18321

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.58%. Comparing base (2a7cc9c) to head (85d930e).

❗ There is a different number of reports uploaded between BASE (2a7cc9c) and HEAD (85d930e). Click for more details.

HEAD has 5 uploads less than BASE

Flag	BASE (2a7cc9c)	HEAD (85d930e)
contracts-bedrock-tests	5	0

Additional details and impacted files

@@                  Coverage Diff                  @@
##           aj/move-game-type   #18433      +/-   ##
=====================================================
- Coverage              75.22%   66.58%   -8.64%     
=====================================================
  Files                    187       55     -132     
  Lines                  11199     4031    -7168     
=====================================================
- Hits                    8424     2684    -5740     
+ Misses                  2631     1203    -1428     
  Partials                 144      144              

Flag	Coverage Δ
cannon-go-tests-64	66.58% <ø> (ø)
contracts-bedrock-tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 132 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.