op-challenger: Introduce generic Player#18441
Merged
Conversation
ajsutton
requested review from
a team and
mbaxter
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## aj/zk-share-clients #18441 +/- ##
=======================================================
- Coverage 80.21% 75.31% -4.91%
=======================================================
Files 132 187 +55
Lines 7168 11199 +4031
=======================================================
+ Hits 5750 8434 +2684
- Misses 1418 2621 +1203
- Partials 0 144 +144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/zk-share-clients
branch
from
8fe89a0 to
c46c3dd
Compare
ajsutton
requested review from
a team and
janjakubnanista
and removed request for
a team
ajsutton
force-pushed
the
aj/generic-player
branch
from
1b9da49 to
519acbc
Compare
ajsutton
force-pushed
the
aj/zk-share-clients
branch
from
c46c3dd to
1bd89b7
Compare
ajsutton
force-pushed
the
aj/generic-player
branch
from
519acbc to
2e8a19a
Compare
Inphi
approved these changes
Dec 2, 2025
Handles common checks before delegating to an actor to progress the game.
ajsutton
force-pushed
the
aj/generic-player
branch
from
2e8a19a to
56c5831
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a generic
Playerimplementation to handle checking sync status and prestate validation before delegating to a game specific actor.Will save duplicating a bunch of boiler plate code for handling ZK games.
Tests
Covered by existing tests. Unit tests moved with production code where appropriate.
Additional context
Builds on #18440
Metadata
#18433