op-challenger: Move GameType to the game/type package instead of game/fault/type#18432
Merged
op-challenger: Move GameType to the game/type package instead of game/fault/type#18432
Conversation
…/fault/type Game types are not specific to fault dispute games.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18432 +/- ##
===========================================
- Coverage 75.60% 75.22% -0.39%
===========================================
Files 187 187
Lines 11199 11199
===========================================
- Hits 8467 8424 -43
- Misses 2586 2631 +45
+ Partials 146 144 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Inphi
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Game types are not specific to fault dispute games. As we introduce ZK games we want to maintain good separation between the fault dispute game handling code and the zk game handling code.
Metadata
#18321