op-challenger: Make client provider a service level concept#18440
Merged
op-challenger: Make client provider a service level concept#18440
Conversation
ajsutton
requested review from
a team and
Inphi
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## aj/remove-trace-type #18440 +/- ##
=========================================================
+ Coverage 66.58% 80.21% +13.63%
=========================================================
Files 55 132 +77
Lines 4031 7168 +3137
=========================================================
+ Hits 2684 5750 +3066
- Misses 1203 1418 +215
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/remove-trace-type
branch
from
85d930e to
17adccf
Compare
ajsutton
requested review from
a team and
geoknee
and removed request for
a team
ajsutton
force-pushed
the
aj/zk-share-clients
branch
from
8fe89a0 to
c46c3dd
Compare
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
Allows clients to be shared between fault and zk game types.
ajsutton
force-pushed
the
aj/zk-share-clients
branch
from
c46c3dd to
1bd89b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows clients to be shared between fault and zk game types.
Tests
Just moved stuff around, existing tests still cover functionality.
Additional context
Builds on #18433
Metadata
#18321