Test cleanup and add solcover #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…po into YAS-467/rollup-contracts/refactor
Contributor
Author
|
Note that the only new functionality within this PR is in: https://github.com/ethereum-optimism/optimism-monorepo/pull/178/files#diff-e097963e3c5e4ab06efcc631731c1aab |
smartcontracts
commented
Jul 6, 2020
| @@ -0,0 +1,35 @@ | |||
| const path = require('path') | |||
Contributor
Author
There was a problem hiding this comment.
General explainer for this file: solcover only gives us the option to skip specific contracts during the instrumentation phase (so we can't explicitly list out the contracts we do want). solcover also doesn't allow us to use globs. This file pulls out the testfiles argument from the coverage script inside package.json and automatically determines the corresponding contract. It then skips all contracts except the corresponding contract.
Contributor
There was a problem hiding this comment.
Could consider putting this explainer in as a comment in the file
karlfloersch
approved these changes
Jul 6, 2020
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
This looks great! Left a few small comments but overall looking good! I didn't do a super in depth look through because it was mostly refactoring, but outside of those issues (/CI passing) I think this is good for a merge!
| Opcode.TIMESTAMP, | ||
| ] | ||
|
|
||
| export const GAS_LIMIT = 1_000_000_000 |
Contributor
There was a problem hiding this comment.
Someday we won't default to a billion gas 😅
| * @param executionManagerAddress The address of the Execution Manager contract for log parsing. | ||
| * @return the converted logs | ||
| */ | ||
| export const convertInternalLogsToOvmLogs = ( |
Contributor
There was a problem hiding this comment.
At some point I believe this should be moved into the rollup-fullnode package (or deleted generally) cc @K-Ho
| @@ -0,0 +1,259 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Oh this should be removed like it was in this PR -- #173
| @@ -39,18 +39,18 @@ | |||
| resolved "https://registry.yarnpkg.com/@ensdomains/resolver/-/resolver-0.2.4.tgz#c10fe28bf5efbf49bff4666d909aed0265efbc89" | |||
Contributor
There was a problem hiding this comment.
Wow pretty large yarn.lock!
Contributor
Author
There was a problem hiding this comment.
Yeah unfortunately this is a side-effect of buidler for now.
| @@ -0,0 +1,35 @@ | |||
| const path = require('path') | |||
Contributor
There was a problem hiding this comment.
Could consider putting this explainer in as a comment in the file
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
* Initial attempt at adding mint to ETH * Fix lint error * fix modifier Co-authored-by: Ben Jones <[email protected]>
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Dec 9, 2024
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Apr 4, 2025
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
ClaytonNorthey92
added a commit
to hemilabs/optimism
that referenced
this pull request
Apr 7, 2025
c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Moves the client programs into the workspace, by using custom build profiles in the virtual workspace for the client binaries. This change will allow us to work on the primary client program within the workspace, without having to have loose crates. A new crate, `kona-common-proc`, has been added as an extension of `kona-common` to make clean `main` functions in client programs. The `#[client_entry(<heap_size>)]` attribute will expand to include a `_start` symbol if the binary is being compiled to a supported FPVM target. If not, it will include a `main` symbol, as normal to run on the native hardware.
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up our tests further and adds
solcoveras a way to check the test coverage of our contracts. Changes are relatively minor, though require modifications to lots of different files. Sorry for the big diff! This is the last cleanup PR before we start to add new tests and contracts.Contributing Agreement