Add Verifier Functionality #168

willmeister · 2020-06-30T14:56:23Z

Description

Adds the ability to verify L1 state root data against L2 state root data, calling a stubbed out Fraud Prover when fraud is detected.

Adds monkey-patch ability for L2 Provider to add L1MessageSender on Transactions
Adds a Chain Data Persister for L1 and L2 in charge of fetching all data of possible interest from their respective chains and persisting them in a useful format for comparison and downstream processing
Adds Data Service, with CRUD operations for relevant data
Adds Verifier that polls L1/L2 data at a configurable frequency to verify that L1 batches match L2 batches

Metadata

Fixes

Fixes # YAS-458

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

…s from getTransaction and getBlock requests and adding test

…ervices

… other future scheduled tasks)

packages/rollup-core/src/app/data/consumers/batch-item-processor.ts

karlfloersch

Alright awesome! This LGTM!!!! Been a long road to get here but I definitely think this stuff has shaped up! I left a couple comments but nothing really to change. Everything seems pretty straightforward and I can't wait to integrate!

packages/rollup-core/src/app/data/consumers/verifier.ts

karlfloersch · 2020-07-02T19:46:30Z

packages/rollup-core/src/app/data/producers/l2-chain-data-persister.ts

+   * @param receipt The TransactionReceipt object.
+   * @returns The combined TransactionAndRoot object.
+   */
+  public static getTransactionAndRoot(


karlfloersch · 2020-07-02T19:47:37Z

packages/rollup-core/src/app/utils.ts

 }
+
+/**
+ * Converts the provided Provider into a Provider capable of parsing L1MessageSender off of


Nice that's very cool

karlfloersch · 2020-07-02T19:50:38Z

packages/rollup-core/src/types/types.ts

+  l1MessageSender?: Address
+  gasLimit?: number
+  l1Timestamp: number
+  l1BlockNumber: number


Awesome. Big fan of the L1 prefix here. Could also be latestL1Timestamp but I am also definitely happy with l1Timestamp

karlfloersch · 2020-07-02T19:52:08Z

packages/rollup-core/src/types/types.ts

  target: Address
  calldata: string
+  sender?: Address
+  l1MessageSender?: Address


Something I've mentioned to Ben but I'll say here as well -- technically we could use the sender field for this value, but we added l1MessageSender to be more explicit. That said, technically using queueOrigin + sender would be sufficient for any L1->L2 tx or even multi-chain txs

karlfloersch · 2020-07-02T19:56:37Z

packages/rollup-core/test/app/l2-provider-compatibility.spec.ts

+        v: '0x25', // 37
+        r: '0x1b5e176d927f8e9ab405058b2d2457392da3e20f328b16ddabcebc33eaac5fea',
+        s: '0x4ba69724e8f69de52f0125ad8b3c5c2cef33019bac3249e2c0a2192766d1721c',
+        l1MessageSender: senderAddress,


I guess eventually we'll need to also include the other fields like queueOrigin , etc. Or encode it in the calldata.

Oh actually something to note (that's not immediately related to this) is that we might want to have some kind of flag in L2Geth which either 1) excludes all these extra fields, or 2) encodes them in the calldata. The reason is because when running things like The Graph or block explorers, they might fail here for the same reason and therefore would require modified providers.

I guess a 3rd option is to modify them to actually parse this info, but that seems like a bit more work off the bat

Sounds good. Definitely open to changing it. Am I reading this correctly to say that there is no action currently required, though?

karlfloersch · 2020-07-02T19:57:13Z

packages/rollup-core/test/app/verifier.spec.ts

+class MockFraudProver implements FraudProver {
+  public readonly provenFraud: Fraud[] = []
+
+  public async proveFraud(


Nice and we'll circle back with @kfichter for the final param requirements when the time comes

)

c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1

…/asterisc lint job (#168) Optimizes the lint jobs by only including the crates with architecture-specific code (`kona-common`) in the `lint-asterisc` and `lint-cannon` recipes. All other crates will be linted entirely with the native lint recipe. We still include all `no_std` crates in the `build` recipes for `cannon` / `asterisc` targets, as these crates still need build coverage to ensure that they always compile to our required targets.

…thereum-optimism#168

@kien-rise

## Motivation We use this pattern downstream (cc @kien-rise): https://github.com/risechain/pevm/blob/bed6f220c343d03e6bef0dc7540c531444450d57/src/chain/optimism.rs#L85-L88 Which doesn't work for `TxEip7702`.  ## Solution Add the missing `From<Signed<TxEip7702>>` for completeness.  ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes

willmeister added 10 commits June 25, 2020 22:58

adding function to monkey-patch Ethers providers to parse transaction…

820d523

…s from getTransaction and getBlock requests and adding test

adding function to monkey-patch Ethers providers to parse transaction…

c87b00a

…s from getTransaction and getBlock requests and adding test

WIP reworking L1 & L2 subs to populate single DB

1ed38c5

First stab at data persister + SQL backend + polling for downstream s…

c3ebd0f

…ervices

Adding L1 Chain Persister tests

5fb2da7

Adding L1 Chain Data Provider tests

639640e

Adding verifier tests, adding ScheduledTask for polling services (and…

9412add

… other future scheduled tasks)

merging yarn.lock

fb64b2f

fixing lint issues

6d60691

fixing issue in ScheduledTask

c95cddf

willmeister commented Jul 2, 2020

View reviewed changes

packages/rollup-core/src/app/data/consumers/batch-item-processor.ts Outdated Show resolved Hide resolved

willmeister added 2 commits July 2, 2020 10:41

Removing batch-item-processor, adding verifier recovery tests

8dcaceb

fixing log statements that would otherwise be too verbose

138a2f8

karlfloersch approved these changes Jul 2, 2020

View reviewed changes

Updating class header per PR review.

6634ff9

willmeister merged commit 9aa71dc into master Jul 2, 2020

willmeister deleted the YAS-458/AddVerifierFunctionality branch July 2, 2020 23:55

snario pushed a commit that referenced this pull request Apr 14, 2021

release: add changelog + automation (#168)

de49aa9

bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024

feat: Refactor configuration and cli of programs (ethereum-optimism#168

61d72a7

)

blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jan 25, 2025

rename sgt from "QKC" to "SoulQKC" (ethereum-optimism#168)

18936b5

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

[ACB-01C] Inefficient Application of Modifiers ethereum-optimism#167 e…

857eed1

…thereum-optimism#168

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Verifier Functionality #168

Add Verifier Functionality #168

Uh oh!

willmeister commented Jun 30, 2020 •

edited

Loading

Uh oh!

Uh oh!

karlfloersch left a comment

Uh oh!

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

willmeister Jul 2, 2020

Uh oh!

karlfloersch Jul 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add Verifier Functionality #168

Add Verifier Functionality #168

Uh oh!

Conversation

willmeister commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Metadata

Fixes

Contributing Agreement

Uh oh!

Uh oh!

karlfloersch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

willmeister commented Jun 30, 2020 •

edited

Loading